GH-45269: [C++][Compute] Add "pivot_wider" and "hash_pivot_wider" functions #45562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g cpp |
|
Revision: 53cff55 Submitted crossbow builds: ursacomputing/crossbow @ actions-d681b13450
|
pitrou
commented
Feb 18, 2025
Comment on lines
+297
to
+303
| // Move away the states and recreate them eagerly, to make sure that any error | ||
| // below does not leave us with empty states. | ||
| auto states = std::move(states_); | ||
| states_.resize(kernels_.size()); | ||
| if (!is_last) { | ||
| RETURN_NOT_OK(ResetKernelStates()); | ||
| } |
There was a problem hiding this comment.
Without this change, any error in MergeAll below could lead to a crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add "pivot wider" functionality such as in Pandas, through two dedicated functions:
Both functions take two arguments (the column of pivot keys and the column of pivot values) and require passing a
PivotWiderOptionsstructure with the expected pivot keys, so as to determine the output Struct type.Are these changes tested?
Yes, by dedicated unit tests.
Are there any user-facing changes?
No, just new APIs.