-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45508: [CI][R] Remove Ubuntu version from sanitizer jobs #45509
Conversation
|
@github-actions crossbow submit test-ubuntu-r-sanitizer test-r-linux-valgrind |
This comment was marked as outdated.
This comment was marked as outdated.
Why not use the more modern Ubuntu 24.04? |
Ah, wait. I was wrong. These jobs already use Ubuntu 22.04 when update Only labels and comments use 20.04. Let's use |
No, I was wrong...
Line 1618 in f8ba543
It uses Ubuntu 22.04: https://github.com/wch/r-debug/blob/13dd42827354c94f9cb4f0bec69c9164c5a700cd/r-devel/Dockerfile#L9 |
Anyway, we can't control Ubuntu version for them. |
@github-actions crossbow submit test-r-linux-sanitizer test-r-linux-valgrind |
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this (and all of the other recent cleanup on this)
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@github-actions crossbow submit test-r-linux-sanitizer test-r-linux-valgrind |
Revision: 700a3df Submitted crossbow builds: ursacomputing/crossbow @ actions-fbe0d04a54
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4e65a94. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
ubuntu-r-sanitizer
andubuntu-r-valgrind
usewch1/r-debug
as their base image.So we can't control Ubuntu versions for them.
What changes are included in this PR?
Remove Ubuntu version from their configurations.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.