Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45508: [CI][R] Remove Ubuntu version from sanitizer jobs #45509

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

kou
Copy link
Member

@kou kou commented Feb 12, 2025

Rationale for this change

ubuntu-r-sanitizer and ubuntu-r-valgrind use wch1/r-debug as their base image.

So we can't control Ubuntu versions for them.

What changes are included in this PR?

Remove Ubuntu version from their configurations.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #45508 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 12, 2025
@kou
Copy link
Member Author

kou commented Feb 12, 2025

@github-actions crossbow submit test-ubuntu-r-sanitizer test-r-linux-valgrind

This comment was marked as outdated.

@pitrou
Copy link
Member

pitrou commented Feb 12, 2025

Why not use the more modern Ubuntu 24.04?

@kou
Copy link
Member Author

kou commented Feb 13, 2025

Ah, wait. I was wrong.

These jobs already use Ubuntu 22.04 when update UBUNTU in .env.

Only labels and comments use 20.04.

Let's use UBUNTU in .env instead of 24.04 for easy to maintain. (If we use UBUNTU in .env, we don't need to update Ubuntu versions for them separately.)

@kou
Copy link
Member Author

kou commented Feb 13, 2025

No, I was wrong...

ubuntu-r-sanitizer uses wch1/r-debug as its base image:

base: wch1/r-debug:latest

It uses Ubuntu 22.04: https://github.com/wch/r-debug/blob/13dd42827354c94f9cb4f0bec69c9164c5a700cd/r-devel/Dockerfile#L9

@kou
Copy link
Member Author

kou commented Feb 13, 2025

ubuntu-r-valgrind uses wch1/r-debug too.

Anyway, we can't control Ubuntu version for them.

@kou kou changed the title GH-45508: [CI][R] Use Ubuntu 22.04 instead of 20.04 for sanitizer jobs GH-45508: [CI][R] Remove Ubuntu version from sanitizer jobs Feb 13, 2025
@kou
Copy link
Member Author

kou commented Feb 13, 2025

@github-actions crossbow submit test-r-linux-sanitizer test-r-linux-valgrind

Copy link

Unable to match any tasks for `test-ubuntu-r-sanitizer`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13298990192

This comment was marked as outdated.

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this (and all of the other recent cleanup on this)

@github-actions github-actions bot added awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting merge Awaiting merge labels Feb 14, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Feb 14, 2025
@kou
Copy link
Member Author

kou commented Feb 14, 2025

@github-actions crossbow submit test-r-linux-sanitizer test-r-linux-valgrind

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Feb 14, 2025
Copy link

Revision: 700a3df

Submitted crossbow builds: ursacomputing/crossbow @ actions-fbe0d04a54

Task Status
test-r-linux-sanitizer GitHub Actions
test-r-linux-valgrind GitHub Actions

@kou kou merged commit 4e65a94 into apache:main Feb 16, 2025
33 of 35 checks passed
@kou kou deleted the ci-r-sanitizer branch February 16, 2025 00:36
@kou kou removed the awaiting changes Awaiting changes label Feb 16, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4e65a94.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants