ARROW-5533: [C++] [Plasma] make plasma client thread safe #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, but it seems like there might be some related test failures in Travis. |
a5b9477 to
6249e98
Compare
Codecov Report
@@ Coverage Diff @@
## master #4503 +/- ##
=========================================
+ Coverage 88.56% 89% +0.43%
=========================================
Files 860 707 -153
Lines 108022 95256 -12766
Branches 1253 0 -1253
=========================================
- Hits 95674 84782 -10892
+ Misses 12069 10474 -1595
+ Partials 279 0 -279
Continue to review full report at Codecov.
|
|
@robertnishihara all travis tests pass now. I changed |
pcmoritz
approved these changes
Jun 14, 2019
|
LGTM, but let's wait for the Ray test suite to pass before merging it! |
6249e98 to
c82ad93
Compare
|
rebased to include #4494 |
shengjun1985
suggested changes
Jun 18, 2019
|
@shengjun1985 that one is specific to mac and seems unrelated. |
shengjun1985
approved these changes
Jun 18, 2019
|
Merging. CI failure looks unrelated to me |
kou
pushed a commit
that referenced
this pull request
Dec 18, 2020
There's a pr #4503 make PlasmaClient thread safe now, but in the doc there's "Note that a PlasmaClient object is not thread safe.", which causes misunderstanding. Closes #8958 from offthewall123/update_plasma_doc_PlasmaClient_ThreadSafe Authored-by: xudingyu <dingyu.xu@intel.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
There's a pr apache#4503 make PlasmaClient thread safe now, but in the doc there's "Note that a PlasmaClient object is not thread safe.", which causes misunderstanding. Closes apache#8958 from offthewall123/update_plasma_doc_PlasmaClient_ThreadSafe Authored-by: xudingyu <dingyu.xu@intel.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make plasma client thread safe, so it's guaranteed when the PlasmaBuffer for an object destructs, the call to plasma_client.Release(object_id) is properly protected. Refer to here for background.
@robertnishihara @pcmoritz