-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44808: [C++][Parquet] Add arrow::Result
version of parquet::arrow::FileReader::GetRecordBatchReader()
#44809
GH-44808: [C++][Parquet] Add arrow::Result
version of parquet::arrow::FileReader::GetRecordBatchReader()
#44809
Conversation
…t::arrow::FileReader::GetRecordBatchReader()` We're migrating `arrow::Status` + output variable API to `arrow::Result` API. * Add `arrow::Result<std::unique_ptr<arrow::RecordBatchReader parquet::arrow::FileReader::GetRecordBatchReader()` * Deprecate `arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()` * Use the added `arrow::Result` version in our code base
@github-actions crossbow submit -g cpp |
|
Revision: 22b0cac Submitted crossbow builds: ursacomputing/crossbow @ actions-336dfe8f67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me! Thanks @kou
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0cdbdac. There were 132 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We're migrating
arrow::Status
+ output variable API toarrow::Result
API.What changes are included in this PR?
arrow::Result<std::unique_ptr<arrow::RecordBatchReader parquet::arrow::FileReader::GetRecordBatchReader()
arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()
arrow::Result
version in our code baseAre these changes tested?
Yes.
Are there any user-facing changes?
Yes.
arrow::Result
version ofparquet::arrow::FileReader::GetRecordBatchReader()
#44808