Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44808: [C++][Parquet] Add arrow::Result version of parquet::arrow::FileReader::GetRecordBatchReader() #44809

Merged

Conversation

kou
Copy link
Member

@kou kou commented Nov 22, 2024

Rationale for this change

We're migrating arrow::Status + output variable API to arrow::Result API.

What changes are included in this PR?

  • Add arrow::Result<std::unique_ptr<arrow::RecordBatchReader parquet::arrow::FileReader::GetRecordBatchReader()
  • Deprecate arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()
  • Use the added arrow::Result version in our code base

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

…t::arrow::FileReader::GetRecordBatchReader()`

We're migrating `arrow::Status` + output variable API to
`arrow::Result` API.

* Add `arrow::Result<std::unique_ptr<arrow::RecordBatchReader parquet::arrow::FileReader::GetRecordBatchReader()`
* Deprecate `arrow::Status parquet::arrow::FileReadeder::GetRecordBatchReader()`
* Use the added `arrow::Result` version in our code base
@kou kou requested a review from wgtmac as a code owner November 22, 2024 08:22
@kou
Copy link
Member Author

kou commented Nov 22, 2024

@github-actions crossbow submit -g cpp

Copy link

⚠️ GitHub issue #44808 has been automatically assigned in GitHub to PR creator.

Copy link

Revision: 22b0cac

Submitted crossbow builds: ursacomputing/crossbow @ actions-336dfe8f67

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-alpine-linux-cpp GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-20.04-cuda-11.2.2 GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-39-cpp GitHub Actions
test-ubuntu-20.04-cpp GitHub Actions
test-ubuntu-20.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me! Thanks @kou

@github-actions github-actions bot added awaiting review Awaiting review awaiting merge Awaiting merge awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review awaiting review Awaiting review awaiting merge Awaiting merge labels Nov 22, 2024
@kou kou merged commit 0cdbdac into apache:main Nov 22, 2024
38 of 39 checks passed
@kou kou deleted the cpp-parquet-reader-get-record-batch-reader-result branch November 22, 2024 22:11
@kou kou removed the awaiting changes Awaiting changes label Nov 22, 2024
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 0cdbdac.

There were 132 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants