Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-43860: [Go][Parquet] Handle the error correctly #43861

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions go/parquet/file/file_reader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,55 @@ func TestRleBooleanEncodingFileRead(t *testing.T) {
assert.Equal(t, expected, values[:len(expected)])
}

type mockBadReader struct {
cnt int
reader *os.File
}

func (m *mockBadReader) Seek(offset int64, whence int) (int64, error) {
return m.reader.Seek(offset, whence)
}

func (m *mockBadReader) ReadAt(p []byte, off int64) (n int, err error) {
if m.cnt == 0 {
return 0, fmt.Errorf("mock error")
}
m.cnt--
return m.reader.ReadAt(p, off)
}

func TestBadReader(t *testing.T) {
dir := os.Getenv("PARQUET_TEST_DATA")
if dir == "" {
t.Skip("no path supplied with PARQUET_TEST_DATA")
}
require.DirExists(t, dir)

filePath := path.Join(dir, "byte_stream_split_extended.gzip.parquet")
f, err := os.Open(filePath)
assert.NoError(t, err)
defer f.Close()

reader := &mockBadReader{
cnt: 2,
reader: f,
}
r, err := file.NewParquetReader(reader, file.WithReadProps(&parquet.ReaderProperties{
BufferSize: int64(1024),
BufferedStreamEnabled: true,
}))
assert.NoError(t, err)

fileReader, err := pqarrow.NewFileReader(r, pqarrow.ArrowReadProperties{}, memory.DefaultAllocator)
assert.NoError(t, err)

columnReader, err := fileReader.GetColumn(context.Background(), 0)
assert.NoError(t, err)

_, err = columnReader.NextBatch(1)
assert.Error(t, err) // Expect an error to occur.
bigsheeper marked this conversation as resolved.
Show resolved Hide resolved
}

func TestByteStreamSplitEncodingFileRead(t *testing.T) {
dir := os.Getenv("PARQUET_TEST_DATA")
if dir == "" {
Expand Down
2 changes: 1 addition & 1 deletion go/parquet/file/record_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ func (rr *recordReader) ReadRecords(numRecords int64) (int64, error) {
}
}

return recordsRead, nil
return recordsRead, rr.Err()
}

func (rr *recordReader) ReleaseValidBits() *memory.Buffer {
Expand Down
Loading