GH-40749: [Python][Packaging] Strip unnecessary symbols when building wheels #42028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit wheel-manylinux-* |
This comment was marked as outdated.
This comment was marked as outdated.
|
This change reduces from 131MB locally unzipped wheel from the previous nightly build to 101MB locally unzipped wheel the wheel on wheel-manylinux-2-28-cp310-amd64. |
|
@jorisvandenbossche @pitrou would you prefer to:
|
-1
+1
+0 |
|
@github-actions crossbow submit wheel-manylinux-* |
|
|
@github-actions crossbow submit wheel-manylinux-* |
|
Revision: 7dd1e28 Submitted crossbow builds: ursacomputing/crossbow @ actions-f4cd718f1d
|
|
Running |
|
@github-actions crossbow submit wheel-macos-* |
|
Revision: aeab32e Submitted crossbow builds: ursacomputing/crossbow @ actions-8a67ea442e
|
|
@github-actions crossbow submit wheel-macos-catalina-cp310-amd64 |
|
Revision: e41c654 Submitted crossbow builds: ursacomputing/crossbow @ actions-9df43f583e
|
|
@github-actions crossbow submit wheel-macos-catalina-cp310-amd64 |
|
Revision: 837d114 Submitted crossbow builds: ursacomputing/crossbow @ actions-1d686e8f7f
|
|
|
pitrou
reviewed
Jun 10, 2024
pitrou
reviewed
Jun 10, 2024
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
|
👍 merging |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit baf4089. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Removing unnecessary symbols for wheels will allow us to reduce the size of the wheels considerably.
What changes are included in this PR?
Running
strip --strip-debugon Linux wheels for all *.so files.Are these changes tested?
Yes, via Archery.
Are there any user-facing changes?
No