Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Dev] Add zanmato1984 and ZhangHuiGui in collaborators list #41544

Merged
merged 1 commit into from
May 6, 2024

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented May 6, 2024

Rationale for this change

Recently zanmato1984 and ZhangHuiGui is active on arrow-compute and arrow-acero module, which lacks maintainer. The contributions can be seem below:

I promote them as collaborators

What changes are included in this PR?

Changes .asf.yaml

Are these changes tested?

No

Are there any user-facing changes?

No

@mapleFU mapleFU requested review from assignUser, kou and raulcd as code owners May 6, 2024 04:38
@github-actions github-actions bot added the awaiting review Awaiting review label May 6, 2024
@jbonofre
Copy link
Member

jbonofre commented May 6, 2024

As reminder the collaborators list is limited to 10 entries.

@mapleFU
Copy link
Member Author

mapleFU commented May 6, 2024

As reminder the collaborators list is limited to 10 entries.

Aha it already has 7 coolaborators now...I'll let the community decide whether we should add them

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mapleFU
As far as I know we could ask ASF infra to increase the number of collaborators but we could also take a look to the list and check when collaborators stop contributing to the project.
I am +1 with the new additions!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 6, 2024
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

In general, we'll invite active collaborators to committers eventually. And we can remove committers from collaborators. So collaborators seat will not be full.
See also: https://arrow.apache.org/committers/#becoming-a-committer

@kou kou changed the title MINOR: add zanmato1984 and ZhangHuiGui in collaborators list MINOR: [Dev] Add zanmato1984 and ZhangHuiGui in collaborators list May 6, 2024
@kou kou merged commit 3a54e68 into apache:main May 6, 2024
9 checks passed
@kou kou removed the awaiting merge Awaiting merge label May 6, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label May 6, 2024
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3a54e68.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…pache#41544)

### Rationale for this change

Recently zanmato1984 and ZhangHuiGui is active on arrow-compute and arrow-acero module, which lacks maintainer. The contributions can be seem below:
* https://github.com/apache/arrow/commits?author=zanmato1984
* https://github.com/apache/arrow/commits?author=ZhangHuiGui

I promote them as collaborators

### What changes are included in this PR?

Changes `.asf.yaml`

### Are these changes tested?

No

### Are there any user-facing changes?

No

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants