-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [Dev] Add zanmato1984 and ZhangHuiGui in collaborators list #41544
Conversation
As reminder the collaborators list is limited to 10 entries. |
Aha it already has 7 coolaborators now...I'll let the community decide whether we should add them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mapleFU
As far as I know we could ask ASF infra to increase the number of collaborators but we could also take a look to the list and check when collaborators stop contributing to the project.
I am +1 with the new additions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
In general, we'll invite active collaborators to committers eventually. And we can remove committers from collaborators. So collaborators seat will not be full.
See also: https://arrow.apache.org/committers/#becoming-a-committer
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 3a54e68. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…pache#41544) ### Rationale for this change Recently zanmato1984 and ZhangHuiGui is active on arrow-compute and arrow-acero module, which lacks maintainer. The contributions can be seem below: * https://github.com/apache/arrow/commits?author=zanmato1984 * https://github.com/apache/arrow/commits?author=ZhangHuiGui I promote them as collaborators ### What changes are included in this PR? Changes `.asf.yaml` ### Are these changes tested? No ### Are there any user-facing changes? No Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Recently zanmato1984 and ZhangHuiGui is active on arrow-compute and arrow-acero module, which lacks maintainer. The contributions can be seem below:
I promote them as collaborators
What changes are included in this PR?
Changes
.asf.yaml
Are these changes tested?
No
Are there any user-facing changes?
No