GH-34966: [Go] Add InsertField and FieldIndex to Schema object #34967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zeroshade
requested changes
Apr 11, 2023
| @@ -197,6 +197,16 @@ func (sc *Schema) FieldIndices(n string) []int { | |||
| return sc.index[n] | |||
| } | |||
|
|
|||
| // FieldIndex return index of the unique field with the given name. | |||
There was a problem hiding this comment.
typo: returns the index
Also, is there a reason to have this in addition to the existing FieldIndices method? A consumer could just do the same length check and use index 0 themselves.
|
@zeroshade I also took a look at the PR and built locally too. |
|
No activity since April, I'm going to close this for now. Feel free to reopen if this is still needed. Thanks! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?