ARROW-274: Add NullableMapVector to support nullable maps #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50a2dae to
8780f48
Compare
|
Aside, has there been any more discussion in drill of removing the |
|
@wesm For now, I'm fixing the gaps between the spec and the java implementation. Once that's done, we can refactor and remove unnecessary layers. |
| int actualSize = super.getBufferSize(); | ||
|
|
||
| Preconditions.checkArgument(expectedSize == actualSize, expectedSize + " != " + actualSize); | ||
| // int expectedSize = getBufferSize(); |
|
+1. The patch looks good to me. Thanks for the works. |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#128 from xhochy/parquet-643 and squashes the following commits: 6f18fca [Uwe L. Korn] PARQUET-643: Add const modifier to schema pointer reference in ParquetFileWriter
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#128 from xhochy/parquet-643 and squashes the following commits: 6f18fca [Uwe L. Korn] PARQUET-643: Add const modifier to schema pointer reference in ParquetFileWriter Change-Id: I1e019444d6154785e062c195d9160e4dd8799a5a
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#128 from xhochy/parquet-643 and squashes the following commits: 6f18fca [Uwe L. Korn] PARQUET-643: Add const modifier to schema pointer reference in ParquetFileWriter Change-Id: I1e019444d6154785e062c195d9160e4dd8799a5a
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#128 from xhochy/parquet-643 and squashes the following commits: 6f18fca [Uwe L. Korn] PARQUET-643: Add const modifier to schema pointer reference in ParquetFileWriter Change-Id: I1e019444d6154785e062c195d9160e4dd8799a5a
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#128 from xhochy/parquet-643 and squashes the following commits: 6f18fca [Uwe L. Korn] PARQUET-643: Add const modifier to schema pointer reference in ParquetFileWriter Change-Id: I1e019444d6154785e062c195d9160e4dd8799a5a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.