Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16102: [C++] Add support for building with system gRPC and bundled GCS #12795

Closed
wants to merge 9 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Apr 5, 2022

find_package(gRPC) may find system absl::* targets.
If we found system absl::* targets, we use them instead of building absl::*.

Bundle google-cloud-cpp is updated to 1.39.0 for
googleapis/google-cloud-cpp#8536 .

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

@kou kou force-pushed the system-grpc-and-bundled-gcs branch from f7686e4 to b030442 Compare April 5, 2022 07:51
@kou
Copy link
Member Author

kou commented Apr 7, 2022

@emkornfield Do you want to merge this before #12763 is merged or after? This will be conflicted with #12763.

This will be ready to merge once https://github.com/apache/arrow/runs/5864515682?check_suite_focus=true is passed.

@kou
Copy link
Member Author

kou commented Apr 7, 2022

@github-actions crossbow submit -g cpp

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Revision: bffc9dc

Submitted crossbow builds: ursacomputing/crossbow @ actions-1823

Task Status
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-21.04-cpp Github Actions

@emkornfield
Copy link
Contributor

@kou thank you very much for the changes. Please go ahead and merge when it is ready, I'll handle the merge conflicts. #12763 still needs review.

@kou
Copy link
Member Author

kou commented Apr 8, 2022

@emkornfield OK. Thanks for confirming it.

@kou
Copy link
Member Author

kou commented Apr 8, 2022

@github-actions crossbow submit -g cpp

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Revision: 9685ef5

Submitted crossbow builds: ursacomputing/crossbow @ actions-1831

Task Status
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-21.04-cpp Github Actions

@kou kou force-pushed the system-grpc-and-bundled-gcs branch from 05798f8 to 3e279ab Compare April 8, 2022 06:03
@kou
Copy link
Member Author

kou commented Apr 8, 2022

@github-actions crossbow submit -g cpp

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Revision: 3e279ab

Submitted crossbow builds: ursacomputing/crossbow @ actions-1832

Task Status
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-18.04-cpp Github Actions
test-ubuntu-18.04-cpp-release Github Actions
test-ubuntu-18.04-cpp-static Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-14 Github Actions
test-ubuntu-20.04-cpp-17 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-21.04-cpp Github Actions

@kou
Copy link
Member Author

kou commented Apr 8, 2022

CI failures are unrelated.

This is ready to merge.

@kou
Copy link
Member Author

kou commented Apr 8, 2022

+1

@kou kou closed this in 5fa0844 Apr 8, 2022
@kou kou deleted the system-grpc-and-bundled-gcs branch April 8, 2022 20:35
@ursabot
Copy link

ursabot commented Apr 9, 2022

Benchmark runs are scheduled for baseline = 29f3873 and contender = 5fa0844. 5fa0844 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.42% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.72% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/480| 5fa08449 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/465| 5fa08449 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/466| 5fa08449 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/475| 5fa08449 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/479| 29f38734 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/464| 29f38734 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/465| 29f38734 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/474| 29f38734 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

jcralmeida pushed a commit to rafael-telles/arrow that referenced this pull request Apr 19, 2022
…led GCS

`find_package(gRPC)` may find system `absl::*` targets.
If we found system `absl::*` targets, we use them instead of building `absl::*`.

Bundle google-cloud-cpp is updated to 1.39.0 for
googleapis/google-cloud-cpp#8536 .

Closes apache#12795 from kou/system-grpc-and-bundled-gcs

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants