Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet][CMake] Thrift dependency doesn't require zlib dependency automatically #45568

Closed
kou opened this issue Feb 19, 2025 · 1 comment
Closed

[C++][Parquet][CMake] Thrift dependency doesn't require zlib dependency automatically #45568

kou opened this issue Feb 19, 2025 · 1 comment
Assignees
@kou
Labels
Component: Parquet Type: bug
Milestone
20.0.0

Comments

@kou
Copy link
Member

kou commented Feb 19, 2025

Describe the bug, including details regarding any error messages, version, and platform.

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 389 to 395 in ec3d283

if(ARROW_THRIFT)
set(ARROW_WITH_ZLIB ON)
endif()
if(ARROW_PARQUET)
set(ARROW_WITH_THRIFT ON)
endif()

This part is wrong:

  • ARROW_THRIFT is a wrong variable name. It should be ARROW_WITH_THRIFT.
  • ARROW_THRIFT check must be done after ARROW_PARQUET check because the ARROW_PARQUET check may set ARROW_WITH_THRIFT.

Component(s)

C++
@kou kou added the Type: bug label Feb 19, 2025
@kou kou changed the title [C++][CMake] Thrift dependency doesn't require zlib dependency automatically [C++][Parquet][CMake] Thrift dependency doesn't require zlib dependency automatically Feb 19, 2025
kou added a commit to kou/arrow that referenced this issue Feb 19, 2025
@kou
apacheGH-45568: [C++][Parquet][CMake] Enable zlib automatically when …
9ac36a6 
…Thrift is needed
@github-actions github-actions bot mentioned this issue Feb 19, 2025
Merged
kou added a commit that referenced this issue Feb 20, 2025
@kou
GH-45568: [C++][Parquet][CMake] Enable zlib automatically when Thrift…
20d8acd 
… is needed (#45569)

### Rationale for this change

Required dependencies checks must be done automatically.

### What changes are included in this PR?

* Fix variable name
* Fix check order

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #45568

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 20.0.0 milestone Feb 20, 2025
@kou
Copy link
Member Author

kou commented Feb 20, 2025

Issue resolved by pull request 45569
#45569

@kou kou closed this as completed Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Parquet Type: bug
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
1 participant
@kou