Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Add bootstrap.R #39147

Closed
assignUser opened this issue Dec 8, 2023 · 0 comments · Fixed by #39148
Closed

[R] Add bootstrap.R #39147

assignUser opened this issue Dec 8, 2023 · 0 comments · Fixed by #39148
Assignees
@assignUser
Labels
Component: R Type: enhancement
Milestone
16.0.0

Comments

@assignUser
Copy link
Member

Describe the enhancement requested

{pkgbuild} can now run a bootstrap.R file automatically before building the package (thanks to @paleolimbot). We can use this to automate preparations for CRAN release.

Component(s)

R
@github-actions github-actions bot mentioned this issue Dec 8, 2023
Merged
@assignUser assignUser mentioned this issue Dec 9, 2023
Open
3 tasks
assignUser added a commit that referenced this issue Mar 21, 2024
@assignUser @paleolimbot
GH-39147: [R] Add Bootstrap.r (#39148)
dc20d95 
### Rationale for this change
Currently installing via github is not possible because the vendoring of the cpp source isn't happening. We can use bootstrap.R to do it. (Does not work for `devtools::install_local()` as that copies the source folder before running bootstrap.R)
 
### What changes are included in this PR?

An R'ified version of `make sync-cpp`

### Are these changes tested?

locally

### Are there any user-facing changes?
Yes, installing via `devtools::install_github()` will now properly vendor the cpp files.

* Closes: #39147
* GitHub Issue: #39147

Lead-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 16.0.0 milestone Mar 21, 2024
@assignUser assignUser mentioned this issue Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assignUser assignUser

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

GH-39147: [R] Add Bootstrap.r assignUser/arrow
1 participant
@assignUser