Revert "Update rand requirement from 0.8 to 0.9 (#7045)" #7125
Conversation
This reverts commit 69eeee3.
|
I don't think we need to revert this for object_store FWIW |
| @@ -53,7 +53,7 @@ arrow-schema = { workspace = true } | |||
| arrow-select = { workspace = true } | |||
| arrow-string = { workspace = true } | |||
|
|
|||
| rand = { version = "0.9", default-features = false, features = ["std", "std_rng", "thread_rng"], optional = true } | |||
| rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true } | |||
There was a problem hiding this comment.
I think we could just revert the changes in this crate
There was a problem hiding this comment.
I think you are right, but it would take me more time to teas apart the PRs. I am instead going to try and back out the entire original PR and then reapply it
I think publically exporting the rand version used by arrow will make such upgrades easier. I'll make a PR |
I tried to explain what is going on on |
|
So what I plan to do is to merge this PR in when it passes the CI. We can discuss publically exporting |
Which issue does this PR close?
54.2.0(~Mar~ Feb 2025) #7083It turns out rand appears in the arrow public API, see
54.2.0(~Mar~ Feb 2025) #7083 (comment)This we can not update
randuntil the next major arrow release55.0.0(Apr 2025) #7084I will also prepare a PR to reapply the change when main open for the nect release
Rationale for this change
What changes are included in this PR?
This reverts commit 69eeee3.
Are there any user-facing changes?
No as this update hasn't been released yet
cc @tustvold and @mbrobbel