Refactor arrow-ipc: Move create_*_array methods into RecordBatchDecoder
#7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
137422c to
e08ad17
Compare
alamb
commented
Feb 6, 2025
| self.require_alignment, | ||
| ), | ||
| ]; | ||
| self.create_primitive_array(field_node, data_type, &buffers) |
There was a problem hiding this comment.
the idea here is to simply call self. instead of free functions like create_primitive_array
alamb
commented
Feb 6, 2025
There was a problem hiding this comment.
The diff is even smaller when viewed without whitespace: https://github.com/apache/arrow-rs/pull/7029/files?w=1
3 tasks
|
@tustvold I wonder if you have some time to review this (very small without whitespace) diff inline with others we have worked on |
tustvold
approved these changes
Feb 8, 2025
|
Thank you for the review @tustvold |
phillipleblanc
pushed a commit
to spiceai/arrow-rs
that referenced
this pull request
Feb 10, 2025
…coder` (apache#7029) * Move `create_primitive_array` into RecordBatchReader * Move `create_list-array` into RecordBatchReader * Move `create_dictionay_array` into RecordBatchReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayReadertoRecodeBatchDecoder#7028Closes #.
Rationale for this change
Continue moving the arrow-ipc deoder functionality into a
structso that flags may be passed downWhat changes are included in this PR?
create_primitive_arrayintoRecordBatchReadercreate_list_arrayintoRecordBatchReadercreate_dictionay_arrayintoRecordBatchReaderAre there any user-facing changes?
No, this is entirely internal reorganizaton