[arrow-cast] Support cast numeric to string view (alternate) #6816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
Omega359
reviewed
Nov 29, 2024
arrow-cast/src/cast/mod.rs
Outdated
| fn test_cast_float_to_utf8view() { | ||
| let inputs = vec![ | ||
| Arc::new(Float16Array::from(vec![ | ||
| Some(f16::from_f64(1.0)), |
There was a problem hiding this comment.
This should be 8.64 & 9.81
There was a problem hiding this comment.
Doh -- I swear I ran these tests but clearly not. Fixed
tustvold
approved these changes
Dec 1, 2024
This was referenced Dec 16, 2024
alamb
added a commit
to alamb/arrow-rs
that referenced
this pull request
Jan 5, 2025
…6816) * [arrow-cast] Support cast numeric to string view Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com> * fix test --------- Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com> Co-authored-by: Tai Le Manh <manhtai.lmt@gmail.com>
alamb
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Based on the work of @tlm365 in #6719
Int,UInt, etc) toUtf8View#6719Rationale for this change
Fill out cast functionality for Utf8View
See more discussion here: #6719 (comment)
What changes are included in this PR?
Add support cast from numeric(Int/Float/Decimal) to string view (Utf8View).
Are there any user-facing changes?
More cast support