Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up filter_run_end_array #6712

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Nov 10, 2024

Which issue does this PR close?

filter run array (kept 1/2)
                        time:   [265.17 µs 266.54 µs 268.32 µs]
                        change: [-48.180% -47.816% -47.483%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
  3 (3.00%) high mild
  5 (5.00%) high severe

filter run array high selectivity (kept 1023/1024)
                        time:   [181.62 µs 182.38 µs 183.26 µs]
                        change: [-17.967% -17.356% -16.742%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  3 (3.00%) high mild
  1 (1.00%) high severe

filter run array low selectivity (kept 1/1024)
                        time:   [137.40 µs 137.83 µs 138.37 µs]
                        change: [-20.107% -19.685% -19.217%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  2 (2.00%) high mild
  3 (3.00%) high severe

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 10, 2024
@Dandandan
Copy link
Contributor Author

FYI @delamarch3

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan -- this makes sense to me


for mut end in run_ends.inner().into_iter().map(|i| (*i).into() as u64) {
let pred: BooleanArray = BooleanBuffer::collect_bool(run_ends.len(), |i| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improvement is due to using BooleanBuffer::collect_bool rather than a builder. That makes sense to me.

@Dandandan Dandandan merged commit eab3326 into apache:master Nov 16, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants