Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Silence compiler warnings for parquet::file::metadata::reader #6457

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Minor: Silence compiler warnings for parquet::file::metadata::reader #6457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b4384
silence compiler warnings
etseidl Sep 26, 2024
6999a22
add async_tests module
etseidl Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions parquet/src/file/metadata/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,15 +638,6 @@ impl ParquetMetaDataReader {
mod tests {
use super::*;
use bytes::Bytes;
#[cfg(feature = "async")]
use futures::future::BoxFuture;
#[cfg(feature = "async")]
use futures::FutureExt;
use std::fs::File;
#[cfg(feature = "async")]
use std::future::Future;
use std::io::{Read, Seek, SeekFrom};
use std::sync::atomic::{AtomicUsize, Ordering};

use crate::basic::SortOrder;
use crate::basic::Type;
Expand Down Expand Up @@ -824,11 +815,27 @@ mod tests {
"EOF: Parquet file too small. Size is 1728 but need 1729"
);
}
}

#[cfg(feature = "async")]
#[cfg(test)]
mod async_tests {
use super::*;
use bytes::Bytes;
use futures::future::BoxFuture;
use futures::FutureExt;
use std::fs::File;
use std::future::Future;
use std::io::{Read, Seek, SeekFrom};
use std::ops::Range;
use std::sync::atomic::{AtomicUsize, Ordering};

use crate::arrow::async_reader::MetadataFetch;
use crate::file::reader::Length;
use crate::util::test_common::file_util::get_test_file;

#[cfg(feature = "async")]
struct MetadataFetchFn<F>(F);

#[cfg(feature = "async")]
impl<F, Fut> MetadataFetch for MetadataFetchFn<F>
where
F: FnMut(Range<usize>) -> Fut + Send,
Expand All @@ -839,7 +846,6 @@ mod tests {
}
}

#[cfg(feature = "async")]
fn read_range(file: &mut File, range: Range<usize>) -> Result<Bytes> {
file.seek(SeekFrom::Start(range.start as _))?;
let len = range.end - range.start;
Expand All @@ -848,7 +854,6 @@ mod tests {
Ok(buf.into())
}

#[cfg(feature = "async")]
#[tokio::test]
async fn test_simple() {
let mut file = get_test_file("nulls.snappy.parquet");
Expand Down Expand Up @@ -934,7 +939,6 @@ mod tests {
assert_eq!(err, "Parquet error: Invalid Parquet file. Corrupt footer");
}

#[cfg(feature = "async")]
#[tokio::test]
async fn test_page_index() {
let mut file = get_test_file("alltypes_tiny_pages.parquet");
Expand Down
Loading