Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warnings that as_any and next_batch are never used #6432

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Silence warnings that as_any and next_batch are never used #6432

merged 1 commit into from
Sep 21, 2024

Conversation

etseidl
Copy link
Contributor

@etseidl etseidl commented Sep 20, 2024

Which issue does this PR close?

Closes #6143.

Rationale for this change

What changes are included in this PR?

See discussion in issue.

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 20, 2024
@diamant3
Copy link

As expected, no warnings showed up according to issue #6143. It looks good to merge this. cc @alamb

alamb
alamb approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @etseidl and @diamant3 for the review

@alamb alamb merged commit bc6009f into apache:master Sep 21, 2024
16 checks passed
@etseidl etseidl deleted the next_batch_warnings branch September 24, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning: methods as_any and next_batch are never used in parquet crate
3 participants
@etseidl @diamant3 @alamb