Refine Display and Source implementation for error types
#5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Jefffrey
reviewed
Feb 27, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Jefffrey
approved these changes
Feb 28, 2024
tustvold
reviewed
Feb 29, 2024
tustvold
reviewed
Feb 29, 2024
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5438.
Rationale for this change
Check the issue for the motivation. Also update the
sourceimplementation to make it consistent with the changes onDisplay.- If there's a prompt ahead of formatting the inner error, provide it as a source error. This is similar to#[source]or#[from]inthiserror.- If there's no prompt but we directly forward the method to the inner error, also forward thesourcemethod. This is similar to#[transparent]inthiserror.What changes are included in this PR?
Are there any user-facing changes?
The description and source of
ArrowErrorandFlightErrorget updated.