Enable running arrow-array and arrow-arith with miri and avoid strict provenance warning #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
approved these changes
Feb 15, 2024
| @@ -202,7 +202,7 @@ fn div_rem_word(hi: u64, lo: u64, divisor: u64) -> (u64, u64) { | |||
| ); | |||
| (quot, rem) | |||
| } | |||
| #[cfg(not(target_arch = "x86_64"))] | |||
| #[cfg(any(not(target_arch = "x86_64"), miri))] | |||
There was a problem hiding this comment.
Ah nice 👍
Didn't realize it was this simple change to get Miri working 👀
Comment on lines
+483
to
+491
| #[cfg(miri)] | ||
| { | ||
| // Since miri implies a nightly rust version we can use the unstable strict_provenance feature | ||
| unsafe { NonNull::new_unchecked(std::ptr::invalid_mut(ALIGNMENT)) } | ||
| } | ||
| #[cfg(not(miri))] | ||
| { | ||
| unsafe { NonNull::new_unchecked(ALIGNMENT as *mut u8) } | ||
| } |
There was a problem hiding this comment.
I'm not as familiar with what's happening here, but I guess as long as it's gated so only affects Miri, should be alright?
There was a problem hiding this comment.
invalid_mut is basically doing the same thing as the cast below, but does not trigger a warning about integer to pointer casts. But it is behind a feature flag and only available on nightly rust.
If you want to go down the rabbit hole of what is pointer provenance, this would be a good point to start: https://github.com/RalfJung/rfcs/blob/provenance/text/0000-rust-has-provenance.md
|
Cheers 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Noticed this while looking into #614, fixes for parquet crate will be done in a separate PR.
Rationale for this change
What changes are included in this PR?
strict-provenancefeature and avoid a warning when creating buffers with zero capacityAre there any user-facing changes?