Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FieldRef in DataType (#3955) #3983

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #3955

Rationale for this change

Switches the remaining DataType variants to using FieldRef

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the api-change Changes to the arrow API label Mar 30, 2023
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Mar 30, 2023
Copy link
Contributor

@crepererum crepererum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change 👍

@tustvold tustvold merged commit 8262b92 into apache:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Cloning of Field
2 participants