Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lexical-core to 1.0 #6397

Closed
Jefffrey opened this issue Sep 15, 2024 · 2 comments · Fixed by #6402
Closed

Bump lexical-core to 1.0 #6397

Jefffrey opened this issue Sep 15, 2024 · 2 comments · Fixed by #6402
Labels
arrow Changes to the arrow crate auto-dependencies enhancement Any new improvement worthy of a entry in the changelog

Comments

@Jefffrey
Copy link
Contributor

Jefffrey commented Sep 15, 2024

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

lexical-core is currently being used for JSON, CSV and cast:

lexical-core = { version = "0.8", default-features = false }

lexical-core = { version = "^0.8", default-features = false }

lexical-core = { version = "^0.8", default-features = false, features = ["write-integers", "write-floats", "parse-integers", "parse-floats"] }

A 1.0.0 release is out now, which fixes some soundness issues.

According to the reddit post, pre 1.0.0 versions will be yanked soon.

Describe the solution you'd like

Bump to lexical-core=1.0.0

Describe alternatives you've considered

Additional context

#5422 may become redundant

We also switched to atoi in this PR for arrow-cast: #5398. Could see if it's worth switching back to lexical-core, if can confirm the correctness issues are resolved and if performance might benefit (otherwise can stay as is).

@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'arrow'} from #6402

@alamb
Copy link
Contributor

alamb commented Oct 2, 2024

label_issue.py automatically added labels {'auto-dependencies'} from #6401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate auto-dependencies enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants