GH-588: [Release] Increase wait interval in dev/release/release_rc.sh
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
approved these changes
Feb 5, 2025
lidavidm
approved these changes
Feb 5, 2025
| @@ -109,13 +109,13 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then | |||
| if [ -n "${run_id}" ]; then | |||
| break | |||
| fi | |||
| sleep 60 | |||
| sleep 600 | |||
There was a problem hiding this comment.
As it's a sleep, it seems so. It's maybe related to @kou network. 10mn is OK though is necessary.
There was a problem hiding this comment.
Ah the issue explains the whole process takes ~30 minutes so ~10 minutes seems reasonable (I guess Github doesn't like pinging too often)
There was a problem hiding this comment.
Yes, it's pretty clear regarding #588 (comment)
There was a problem hiding this comment.
Yes.
I've added it to this PR description too. Sorry. I should have explained it in the PR description too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-588.
release.ymltakes at least 30min now. So 60s wait interval is too short. We can use longer interval to avoid needless API requests.