GH-549: Fix Incorrect NOTICE File and Update LICENSE Headers for Third-Party Code Compliance #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jan 21, 2025
kou
reviewed
Jan 21, 2025
| @@ -205,13 +205,13 @@ | |||
| vector/src/main/java/org/apache/arrow/vector/util/IntObjectHashMap.java | |||
| vector/src/main/java/org/apache/arrow/vector/util/IntObjectMap.java | |||
|
|
|||
| These file are derived from code from Netty, which is made available under the | |||
| These file are derived from code from Netty(4.1.117), which is made available under the | |||
There was a problem hiding this comment.
Could you add how to determine this (and other changes such as Guava 33.4.0 and the license header) to the PR description? e.g. commit ID you referred.
It's for easy to trace. We'll use the PR description for commit message.
There was a problem hiding this comment.
Done, I also updated my commit log：）
… Third-Party Code Compliance The files IntObjectMap.java and IntObjectHashMap.java are sourced from: https://github.com/netty/netty/tree/netty-4.1.117.Final/common/src/main/templates/io/netty/util/collection/ (Specific types will be generated during the compilation phase, but fundamentally, no change in intellectual property ownership has occurred.) The Guava code is sourced from: https://github.com/google/guava/blob/v33.4.0/guava/src/com/google/common/base/Preconditions.java Given the possibility of changes to the license, the specific version has been noted to help reduce ambiguity.
b301a4e to
e40d2ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files IntObjectMap.java and IntObjectHashMap.java are sourced from:
https://github.com/netty/netty/tree/netty-4.1.117.Final/common/src/main/templates/io/netty/util/collection/
(Specific types will be generated during the compilation phase, but fundamentally, no change in intellectual property ownership has occurred.)
The Guava code is sourced from:
https://github.com/google/guava/blob/v33.4.0/guava/src/com/google/common/base/Preconditions.java
Given the possibility of changes to the license, the specific version has been noted to help reduce ambiguity.
close #549