GH-20: Add CONTRIBUTING.md #162
Conversation
CONTRIBUTING.md
Outdated
| your GitHub account, navigate to [GitHub issues](https://github.com/apache/arrow-go/issues) | ||
| and click on **New issue** . | ||
|
|
||
| To be assigned to an issue, add a comment "take" to that issue. |
There was a problem hiding this comment.
We don't have this feature in apache/arrow-go.
Do we need this? If we need this, we need to port https://github.com/apache/arrow/blob/0c3206772051c52fe2e648623daaca2c4e71cb72/.github/workflows/comment_bot.yml#L178-L194 to apache/arrow-go.
There was a problem hiding this comment.
I think it might be a good idea for us to port that, it's likely useful
CONTRIBUTING.md
Outdated
| ## Do you want to propose a significant new feature or an important refactoring? | ||
|
|
||
| We ask that all discussions about major changes in the codebase happen | ||
| publicly on the [arrow-dev mailing-list](https://mail-archives.apache.org/mod_mbox/arrow-dev/). |
There was a problem hiding this comment.
https://arrow.apache.org/community/#mailing-lists may be better because it has a bit more description.
CONTRIBUTING.md
Outdated
| We'll ask you to prefix the pull request title with the GitHub issue number | ||
| and the component name in brackets. (for example: "GH-100: [Parquet] | ||
| fix panic in record read"). Respecting this convention | ||
| makes it easier for us to process the backlog of submitted Pull Requests. |
There was a problem hiding this comment.
We can stop this convention if we want. I think that this convention is to associate Jira issue easily.
We can use Fixes #XXX PR description in GitHub instead.
There was a problem hiding this comment.
I'd be more than willing to update to instead use conventional commits and then I can update the automation to auto generate the semantic versioning from the conventional commit messages. Thoughts?
There was a problem hiding this comment.
Like ADBC does, right?
It's a good idea.
Fixes #20