-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support openresty-1.25.3.1 #10887
feat: support openresty-1.25.3.1 #10887
Conversation
This reverts commit 9fcb781.
Please fix the code lint error in ci |
@monkeyDluffy6017 Could you help me rerun the CI? |
@monkeyDluffy6017 Could you help me rerun the failed CI? |
Maybe you could remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #6403
Breaking Change:
enable_http2
is set for any entry underapisix.ssl.listen
orapisix.ssl.node_listen
, all entries willenable http2
. Becuase nginx-1.25.3 change the configuration of http2from
to
From user perspective, if I have following configuration, the port
9443
and9444
will both support http2. Theenable_http2: false
takes no effect for port9444
ngx.req.read_body
need HTTP/2 or HTTP/3 request must has acontent-length
header which is introduced in https://github.com/openresty/lua-nginx-module/tree/v0.10.26. Even for GET request, we still need sent the headercontent-length: 0
whether we callngx.req.read_body
directly or indrectly. such as https://github.com/apache/apisix/pull/10887/files#diff-d099a6d3ec103fc01c1d4354f7e3659002bd53c8bb5013b26d7ec0b88910074fR192-R193doc for ngx.req.read_body from lua-nginx-module-0.10.26
QUIC
of nginx needsQUIC TLS
which tongsuo does not support currently.related PRs:
Checklist