[AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0 #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandeep318kumar Thank you very much for your contribution. Please check the CI/CD for this PR. |
|
@sandeep318kumar build has failed, can you kindly check the failure for missing library, try excluding the same. |
bb9163e to
d3335ac
Compare
d3335ac to
0822671
Compare
|
JiaLiangC
reviewed
Sep 18, 2024
...rg/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java
Show resolved
Hide resolved
Comment on lines
+325
to
+344
| @Override | ||
| public void delete(TimelineAppMetricCacheKey key) throws CacheWritingException { | ||
| // no need to implement. | ||
| } | ||
|
|
||
| @Override | ||
| public Map<TimelineAppMetricCacheKey, TimelineMetricsCacheValue> loadAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheLoadingException, Exception { | ||
| // no need to implement. | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| public void writeAll(Iterable<? extends Map.Entry<? extends TimelineAppMetricCacheKey, ? extends TimelineMetricsCacheValue>> entries) throws BulkCacheWritingException, Exception { | ||
| // no need to implement. | ||
| } | ||
|
|
||
| @Override | ||
| public void deleteAll(Iterable<? extends TimelineAppMetricCacheKey> keys) throws BulkCacheWritingException, Exception { | ||
| // no need to implement. | ||
| } |
There was a problem hiding this comment.
If the code here is not specifically implemented, can it be removed？
There was a problem hiding this comment.
@JiaLiangC
We are implementing CacheLoaderWriter interface, that's why we need to provide implementation of all its methods.
|
@virajjasani Could also check this pr? |
|
@arshadmohammad @vishalsuvagia Can you check this PR? |
JiaLiangC
approved these changes
Sep 24, 2024
xijunmu
added a commit
to xijunmu/ambari
that referenced
this pull request
Sep 29, 2024
This reverts commit b6a3185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[AMBARI-26076] Upgrade net.sf.ehcache to 3.10.0
(Please fill in changes proposed in this fix)
How was this patch tested?
Installed a local with the changes and tested all functionalities. All metrics are coming in ambari UI. Check https://issues.apache.org/jira/browse/AMBARI-26076 for references
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.