[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #7153

Bruschkov · 2020-01-13T14:11:34Z

JIRA

https://issues.apache.org/jira/browse/AIRFLOW-6585

Description

When using the KubernetesPodOperator on an aws kubernetes cluster, the aws-iam-authenticator is used to obtain kubernetes authentication tokens. The aws tokens contain ISO-8601 formatted timestamps, which couldn't be parsed in case of a "Z" (Zulu Time) timezone. This PR fixes this problem by converting the "Z" timezone into a regular "+0000" format.

Upon further review this is only a problem with python version <= 3.6. But that should not keep the issue from being fixed.

boring-cyborg · 2020-01-13T14:11:39Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)

Here are some useful points:

Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits
will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory).
Adding a new operator? Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.

Apache Airflow is a community-driven project and together we are making it better 🚀.

In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

potiuk

I'd still prefer to have a test for that one. This should b e rather easy to add such test.

There is already the tests/kubernetes/test_client.py with two tests and adding a test there would be just great (we need to improve coverage on Kubernetes part and even really small tests like that gradually added help a lot)

Would you be so nice to add it please?

codecov-io · 2020-01-13T16:15:43Z

Codecov Report

❗ No coverage uploaded for pull request base (master@e7bf8ec). Click here to learn what that means.
The diff coverage is 83.33%.

@@           Coverage Diff            @@
##             master   #7153   +/-   ##
========================================
  Coverage          ?   85.4%           
========================================
  Files             ?     710           
  Lines             ?   39484           
  Branches          ?       0           
========================================
  Hits              ?   33723           
  Misses            ?    5761           
  Partials          ?       0

Impacted Files	Coverage Δ
airflow/kubernetes/refresh_config.py	`76.78% <83.33%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7bf8ec...ce626e1. Read the comment docs.

Bruschkov · 2020-01-14T14:32:49Z

I'd still prefer to have a test for that one. This should b e rather easy to add such test.

There is already the tests/kubernetes/test_client.py with two tests and adding a test there would be just great (we need to improve coverage on Kubernetes part and even really small tests like that gradually added help a lot)

Would you be so nice to add it please?

Hi, thanks for your quick feedback. Added the test and amended the PR.

Bruschkov · 2020-01-15T09:54:12Z

@potiuk

Everything solved and build passes now.

Best regards

ashb · 2020-01-16T16:39:30Z

Change looks good now, but as this JIRA was already released we need a new JIRA please. (We use the Fix Version to know what to pull back to our releases, and as AIRFLOW-5117 is already released we would otherwise miss this change when building 1.10.8)

ashb

Please create new Jira ticket for this.

Bruschkov · 2020-01-21T08:48:10Z

@ashb New JIRA created and linked to this PR.

mik-laj · 2020-02-02T19:42:51Z

Why are these changes being made in this project and not in the Kubernetes library? I can't find the ticket in the library repository.

Bruschkov · 2020-02-03T08:07:24Z

Why are these changes being made in this project and not in the Kubernetes library? I can't find the ticket in the library repository.

#5731 (comment)

stale · 2020-04-07T04:20:57Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ashb · 2020-04-08T11:19:22Z

airflow/kubernetes/refresh_config.py

@@ -32,6 +32,15 @@
 from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION, KubeConfigLoader


+def _parse_timestamp(ts_str: str) -> int:
+    if ts_str[-1] == 'Z':


Using pendulum (which we already use) might be a better fix than this.

stale · 2020-05-23T21:30:20Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

benjaminsky · 2020-07-17T22:37:32Z

This is still an issue with EKS and Airflow v1.10.10. This PR fixes it. Can we reopen this PR?

potiuk · 2020-07-19T08:11:51Z

@benjaminsky -> sure, would you mind picking this up? I think this one neds rebase and there is a change requested. Unnless (@Bruschkov wants to do it).

stale · 2020-09-02T11:09:48Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ramsesrm · 2020-09-30T09:49:30Z

Hi, this is still an issue on Airflow v1.10.12. Can we reopen the PR?

[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps

6bf555b

boring-cyborg bot added the k8s label Jan 13, 2020

potiuk reviewed Jan 13, 2020

View reviewed changes

mik-laj changed the title ~~[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps~~ [AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader Jan 13, 2020

[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps

ca31593

Jan Brusch added 2 commits January 14, 2020 16:49

[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps

4e92498

[AIRFLOW-5117] Fixed Bug with ISO-8601 Timestamps

ce626e1

ashb requested changes Jan 16, 2020

View reviewed changes

Bruschkov changed the title ~~[AIRFLOW-5117] Fixed Timestamp bug in RefreshKubeConfigLoader~~ [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader Jan 17, 2020

Bruschkov requested a review from ashb January 17, 2020 08:12

bhtucker mentioned this pull request Jan 28, 2020

[AIRFLOW-5117] support refreshing EKS api tokens #5731

Merged

6 tasks

kaxil requested a review from dimberman February 22, 2020 01:10

stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 7, 2020

ashb reviewed Apr 8, 2020

View reviewed changes

stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 8, 2020

stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 23, 2020

stale bot closed this May 30, 2020

potiuk reopened this Jul 19, 2020

stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 19, 2020

stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 2, 2020

stale bot closed this Sep 11, 2020

Seltsamsel mentioned this pull request Oct 1, 2020

[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #11219

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #7153

[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #7153

Bruschkov commented Jan 13, 2020 •

edited

Loading

boring-cyborg bot commented Jan 13, 2020

potiuk left a comment

codecov-io commented Jan 13, 2020 •

edited

Loading

Bruschkov commented Jan 14, 2020

Bruschkov commented Jan 15, 2020

ashb commented Jan 16, 2020

ashb left a comment

Bruschkov commented Jan 21, 2020

mik-laj commented Feb 2, 2020

Bruschkov commented Feb 3, 2020

stale bot commented Apr 7, 2020

ashb Apr 8, 2020

stale bot commented May 23, 2020

benjaminsky commented Jul 17, 2020

potiuk commented Jul 19, 2020

stale bot commented Sep 2, 2020

ramsesrm commented Sep 30, 2020

[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #7153

[AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader #7153

Conversation

Bruschkov commented Jan 13, 2020 • edited Loading

JIRA

Description

boring-cyborg bot commented Jan 13, 2020

potiuk left a comment

Choose a reason for hiding this comment

codecov-io commented Jan 13, 2020 • edited Loading

Codecov Report

Bruschkov commented Jan 14, 2020

Bruschkov commented Jan 15, 2020

ashb commented Jan 16, 2020

ashb left a comment

Choose a reason for hiding this comment

Bruschkov commented Jan 21, 2020

mik-laj commented Feb 2, 2020

Bruschkov commented Feb 3, 2020

stale bot commented Apr 7, 2020

ashb Apr 8, 2020

Choose a reason for hiding this comment

stale bot commented May 23, 2020

benjaminsky commented Jul 17, 2020

potiuk commented Jul 19, 2020

stale bot commented Sep 2, 2020

ramsesrm commented Sep 30, 2020

Bruschkov commented Jan 13, 2020 •

edited

Loading

codecov-io commented Jan 13, 2020 •

edited

Loading