Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider moving/microsoft azure #46254

Merged
merged 29 commits into from
Feb 8, 2025

Conversation

kunaljubce
Copy link
Contributor

Relates to #46045, moving microsoft.azure provider to new folder structure.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Feb 5, 2025

This provider is already moved

Ah no ... sorry - it's not

@potiuk
Copy link
Member

potiuk commented Feb 5, 2025

tests need to be fixed/

@kunaljubce
Copy link
Contributor Author

tests need to be fixed/

Yeah, working on the tests right now. Should be done in the next couple of days!

@potiuk
Copy link
Member

potiuk commented Feb 7, 2025

tests need to be fixed/

Yeah, working on the tests right now. Should be done in the next couple of days!

Cool. If you need any help - let me know :)

@kunaljubce
Copy link
Contributor Author

Compat tests finally passed 🤯

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Compat tests finally passed 🤯

Woooooooo!

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

I am looking at the strange:

  ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
  pytest: error: unrecognized arguments: --warning-output-path=/files/warnings-providers_microsoft_azure-postgres.txt --with-db-init

I think the problem is with some conftest.py missing. Those flags are coming from airflow's tests_common and tests_common should be included by the pytest_plugin in conftes.py -> so something is wrong in the `microsoft.azure' conftest.py I think

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Ah yeah.pytst_plugin is missing. Let me push a fixup real quick :)

@kunaljubce
Copy link
Contributor Author

Yeah I am also checking that one Jarek

@potiuk potiuk marked this pull request as ready for review February 8, 2025 17:49
@kunaljubce
Copy link
Contributor Author

Ah yeah.pytst_plugin is missing. Let me push a fixup real quick :)

Thanks!

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Let's see 🤞 :)

@potiuk potiuk force-pushed the provider-moving/microsoft-azure branch from 898c02e to 9ff9a0d Compare February 8, 2025 18:44
@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Ah.. I forgot we need to set pytest_plugins before importing airflow :)

@potiuk potiuk force-pushed the provider-moving/microsoft-azure branch from 9ff9a0d to 996e71b Compare February 8, 2025 20:18
@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Seems even more things - with imports...

@potiuk
Copy link
Member

potiuk commented Feb 8, 2025

Green! Merging :)

@potiuk potiuk merged commit fd606b1 into apache:main Feb 8, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants