Get rid of AssetAliasCondition #44708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a separate class for condition evaluation, we can just use the main AssetAlias class directly. While it technically makes sense to subclass AssetAny, AssetAliasCondition does not really reuse much of its implementation, and we can just implement the missing methods ourselves instead. Whether the class actually is an AssetAny does not really make much of a difference. This actually allows us to simplify quite some code (including tests) a bit since we don't need to rewrap AssetAlias back and forth.
Lee-W
approved these changes
Dec 6, 2024
Ohashiro
pushed a commit
to Ohashiro/airflow
that referenced
this pull request
Dec 6, 2024
* Get rid of AssetAliasCondition Instead of having a separate class for condition evaluation, we can just use the main AssetAlias class directly. While it technically makes sense to subclass AssetAny, AssetAliasCondition does not really reuse much of its implementation, and we can just implement the missing methods ourselves instead. Whether the class actually is an AssetAny does not really make much of a difference. This actually allows us to simplify quite some code (including tests) a bit since we don't need to rewrap AssetAlias back and forth. * Fix serialization test * Does not need this call * Remove resolution-dependant timetable summary
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
* Get rid of AssetAliasCondition Instead of having a separate class for condition evaluation, we can just use the main AssetAlias class directly. While it technically makes sense to subclass AssetAny, AssetAliasCondition does not really reuse much of its implementation, and we can just implement the missing methods ourselves instead. Whether the class actually is an AssetAny does not really make much of a difference. This actually allows us to simplify quite some code (including tests) a bit since we don't need to rewrap AssetAlias back and forth. * Fix serialization test * Does not need this call * Remove resolution-dependant timetable summary
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Get rid of AssetAliasCondition Instead of having a separate class for condition evaluation, we can just use the main AssetAlias class directly. While it technically makes sense to subclass AssetAny, AssetAliasCondition does not really reuse much of its implementation, and we can just implement the missing methods ourselves instead. Whether the class actually is an AssetAny does not really make much of a difference. This actually allows us to simplify quite some code (including tests) a bit since we don't need to rewrap AssetAlias back and forth. * Fix serialization test * Does not need this call * Remove resolution-dependant timetable summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a separate class for condition evaluation, we can just use the main AssetAlias class directly. While it technically makes sense to subclass AssetAny, AssetAliasCondition does not really reuse much of its implementation, and we can just implement the missing methods ourselves instead. Whether the class actually is an AssetAny does not really make much of a difference.
This actually allows us to simplify quite some code (including tests) a bit since we don't need to rewrap AssetAlias back and forth.