Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provider Deprecations in Redis #44633

Merged

Conversation

jason810496
Copy link
Contributor

related: #44559


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jason810496
Copy link
Contributor Author

It seems like the CI failed due to changes related to Assets, rather than the current removal changes. The failing test case hasn’t been modified and doesn’t appear to be related to the provider changes.

E   sqlalchemy.exc.InvalidRequestError: When initializing mapper mapped class AssetModel->asset, expression 'Trigger' failed to locate a name ('Trigger'). If this is a class name, consider adding this relationship() to the <class 'airflow.models.asset.AssetModel'> class after both dependent classes have been defined.

@Lee-W
Copy link
Member

Lee-W commented Dec 5, 2024

It seems like the CI failed due to changes related to Assets, rather than the current removal changes. The failing test case hasn’t been modified and doesn’t appear to be related to the provider changes.

E   sqlalchemy.exc.InvalidRequestError: When initializing mapper mapped class AssetModel->asset, expression 'Trigger' failed to locate a name ('Trigger'). If this is a class name, consider adding this relationship() to the <class 'airflow.models.asset.AssetModel'> class after both dependent classes have been defined.

Looks like an AIP-82 one, not sure what's happening 🤔 let me rebase and see how it works

@Lee-W Lee-W force-pushed the feature/remove-provider-deprecations-redis branch from 75bee36 to 0fe95c5 Compare December 5, 2024 08:53
@jason810496 jason810496 force-pushed the feature/remove-provider-deprecations-redis branch from 0fe95c5 to 4ae21b0 Compare December 5, 2024 13:00
@jason810496 jason810496 marked this pull request as draft December 5, 2024 13:46
@jason810496 jason810496 marked this pull request as draft December 5, 2024 13:46
@jason810496 jason810496 force-pushed the feature/remove-provider-deprecations-redis branch from 4ae21b0 to 4472ad1 Compare December 6, 2024 13:25
@jason810496 jason810496 marked this pull request as ready for review December 6, 2024 13:25
@jason810496 jason810496 force-pushed the feature/remove-provider-deprecations-redis branch from 4472ad1 to d5ff66e Compare December 6, 2024 16:30
@jscheffl jscheffl merged commit ee6f6fb into apache:main Dec 6, 2024
65 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* Remove Provider Deprecations in Redis

* Fix mock_get_connection in test_redis
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Remove Provider Deprecations in Redis

* Fix mock_get_connection in test_redis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants