Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated code from Alibaba provider package #44576

Conversation

Tushar4432
Copy link
Contributor

@Tushar4432 Tushar4432 commented Dec 2, 2024

Relates to: #44559

Removed deprecated code from the Alibaba providers.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Dec 2, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Tushar4432 Tushar4432 changed the title issue 44559 Removed Depricated code from alibaba provider Dec 2, 2024
@Tushar4432 Tushar4432 closed this Dec 3, 2024
@Tushar4432 Tushar4432 reopened this Dec 3, 2024
@shahar1 shahar1 changed the title Removed Depricated code from alibaba provider Removed deprecated code from Alibaba provider package Dec 3, 2024
@shahar1 shahar1 self-requested a review December 3, 2024 21:08
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Apache Airflow and thank you for your contribution, great job!
Could you please remove the now redundant imports? :)

@shahar1 shahar1 self-requested a review December 3, 2024 21:10
@potiuk
Copy link
Member

potiuk commented Dec 10, 2024

That's the LAST one @Tushar4432 -> shall you rebase/apply the comments so that we can close #44559 🚀 ?

@eladkal eladkal force-pushed the issue44559/removed_deprecated_code_alibaba_provider branch from 1de66ad to 405e723 Compare December 10, 2024 08:20
Tushar4432 and others added 2 commits December 16, 2024 14:23
removed depricated code from alibaba provider
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
@eladkal eladkal force-pushed the issue44559/removed_deprecated_code_alibaba_provider branch from 405e723 to 3f69dde Compare December 16, 2024 12:23
@potiuk potiuk merged commit 33a809c into apache:main Dec 16, 2024
65 checks passed
Copy link

boring-cyborg bot commented Dec 16, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* issue 44559

removed depricated code from alibaba provider

* Apply suggestions from code review

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* issue 44559

removed depricated code from alibaba provider

* Apply suggestions from code review

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants