-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed deprecated code from Alibaba provider package #44576
Removed deprecated code from Alibaba provider package #44576
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Apache Airflow and thank you for your contribution, great job!
Could you please remove the now redundant imports? :)
providers/src/airflow/providers/alibaba/cloud/operators/analyticdb_spark.py
Outdated
Show resolved
Hide resolved
providers/src/airflow/providers/alibaba/cloud/sensors/analyticdb_spark.py
Outdated
Show resolved
Hide resolved
That's the LAST one @Tushar4432 -> shall you rebase/apply the comments so that we can close #44559 🚀 ? |
1de66ad
to
405e723
Compare
removed depricated code from alibaba provider
Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
405e723
to
3f69dde
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* issue 44559 removed depricated code from alibaba provider * Apply suggestions from code review Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
* issue 44559 removed depricated code from alibaba provider * Apply suggestions from code review Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> --------- Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com> Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
Relates to: #44559
Removed deprecated code from the Alibaba providers.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.