Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AIP-44 from dag processing manager and internal_api_call #44549

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 1, 2024

This is the last "internal_api_call" change from AIP-44 removal and it not only removes the dag_processsing/manager calls but also the internal_api_call itself.

Part of #44436


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

This is the last "internal_api_call" change from AIP-44 removal
and it not only removes the dag_processsing/manager calls but also
the internal_api_call itself.

Part of apache#44436
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Dec 1, 2024
@potiuk
Copy link
Member Author

potiuk commented Dec 1, 2024

cc: @jason810496

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wohoo, house is clean!

@jscheffl
Copy link
Contributor

jscheffl commented Dec 1, 2024

...ah wheres still some cleaning and removal in airflow/serialization/pydantic/** is needed as well?
Will airflow/serialization/** actually also be removed or will this stay? (I assume we don't need this with the old API, correct?)

@potiuk
Copy link
Member Author

potiuk commented Dec 1, 2024

...ah wheres still some cleaning and removal in airflow/serialization/pydantic/** is needed as well?
Will airflow/serialization/** actually also be removed or will this stay? (I assume we don't need this with the old API, correct?)

Yep. there is one more step in #44436 - remove all *Pydantic classes aand that's part of it. One problem there is that Pydantic classes are currently used as a way to serialize Context for PythonVirtualenvOperator and ExternalPythonOperator - so we cannot remove them "as-is" - we have to provide a replacement - which is likely tied to the Task SDK API changes - cc: @ashb @kaxil

@potiuk potiuk merged commit 6ef7403 into apache:main Dec 1, 2024
50 checks passed
@potiuk potiuk deleted the remove-internal-api-call-completely branch December 1, 2024 22:23
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
…che#44549)

This is the last "internal_api_call" change from AIP-44 removal
and it not only removes the dag_processsing/manager calls but also
the internal_api_call itself.

Part of apache#44436
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…che#44549)

This is the last "internal_api_call" change from AIP-44 removal
and it not only removes the dag_processsing/manager calls but also
the internal_api_call itself.

Part of apache#44436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants