Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AIP-44 from taskinstance #44540

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 1, 2024

Part of #44436


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:CLI area:core-operators Operators, Sensors and hooks within Core Airflow area:logging area:providers area:Scheduler including HA (high availability) scheduler area:serialization provider:amazon AWS/Amazon - related issues provider:standard labels Dec 1, 2024
@potiuk potiuk requested review from rawwar and jscheffl December 1, 2024 17:12
@potiuk
Copy link
Member Author

potiuk commented Dec 1, 2024

I want to make this one pass - and then - separately - do refactoring with merging those changes in task instance.

@potiuk potiuk force-pushed the remove-aip-44-task-unstance branch from 29509e8 to 5fd0e92 Compare December 1, 2024 17:14
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 small santity check questions, else looks good in my view as a first pass cleaning.

@jscheffl jscheffl added the full tests needed We need to run full set of tests for this PR to merge label Dec 1, 2024
@jscheffl
Copy link
Contributor

jscheffl commented Dec 1, 2024

I'm adding "full tests needed" as I think especially the task instance is a "danger zone" of side effects - same as we had with sensor base.py changes.

@potiuk potiuk force-pushed the remove-aip-44-task-unstance branch from 5fd0e92 to 04a937f Compare December 1, 2024 17:37
@potiuk potiuk force-pushed the remove-aip-44-task-unstance branch from 04a937f to 6f706e6 Compare December 1, 2024 17:42
@potiuk potiuk merged commit 62bac46 into apache:main Dec 1, 2024
97 checks passed
@potiuk potiuk deleted the remove-aip-44-task-unstance branch December 1, 2024 18:47
@potiuk potiuk mentioned this pull request Dec 1, 2024
17 tasks
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Part of apache#44436

Co-authored-by: kalyanr <kalyan.ben10@live.com>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Part of apache#44436

Co-authored-by: kalyanr <kalyan.ben10@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:core-operators Operators, Sensors and hooks within Core Airflow area:logging area:providers area:Scheduler including HA (high availability) scheduler area:serialization full tests needed We need to run full set of tests for this PR to merge provider:amazon AWS/Amazon - related issues provider:standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants