-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AIP-44 from taskinstance #44540
Conversation
I want to make this one pass - and then - separately - do refactoring with merging those changes in task instance. |
29509e8
to
5fd0e92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 small santity check questions, else looks good in my view as a first pass cleaning.
providers/src/airflow/providers/amazon/aws/transfers/google_api_to_s3.py
Show resolved
Hide resolved
I'm adding "full tests needed" as I think especially the task instance is a "danger zone" of side effects - same as we had with sensor base.py changes. |
5fd0e92
to
04a937f
Compare
04a937f
to
6f706e6
Compare
Part of apache#44436 Co-authored-by: kalyanr <kalyan.ben10@live.com>
Part of apache#44436 Co-authored-by: kalyanr <kalyan.ben10@live.com>
Part of #44436
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.