Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX make CloudBatchSubmitJobOperator fail when job fails #44425

Merged
merged 3 commits into from
Nov 30, 2024
Merged

FIX make CloudBatchSubmitJobOperator fail when job fails #44425

merged 3 commits into from
Nov 30, 2024

Conversation

SuccessMoses
Copy link
Contributor

Fixes : #43744

TODO:

  • Improve unit test for CloudBatchSunbmitJobOperator

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 27, 2024
MaksYermak
MaksYermak approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@MaksYermak MaksYermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk
Copy link
Member

potiuk commented Nov 28, 2024

Yeah - as already planned - can you please add a unit test and get a better description in commit message @SuccessMoses ?

@SuccessMoses
Copy link
Contributor Author

@potiuk I made a minor change to the test. Do you think more test is needed?

shahar1
shahar1 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@potiuk
Copy link
Member

potiuk commented Nov 30, 2024

Yep. Nice work - the failing tests are also failing in main and we need to fix them separately, so this one is goood to go.

@potiuk potiuk merged commit 4d90f14 into apache:main Nov 30, 2024
61 of 65 checks passed
@SuccessMoses SuccessMoses deleted the fix-gcbatch-operator branch November 30, 2024 19:24
@SuccessMoses
Copy link
Contributor Author

@potiuk Thanks for merging. The failing test on main, is it something that is fixable? I won't like to give it a try too

@potiuk
Copy link
Member

potiuk commented Nov 30, 2024

Workarounded already - and waits for a permanent fix here #44513

@eladkal eladkal mentioned this pull request Dec 22, 2024
Closed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
@SuccessMoses
Make CloudBatchSubmitJobOperator fail when job fails (apache#44425)
589c2a9
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@SuccessMoses @got686-yandex
Make CloudBatchSubmitJobOperator fail when job fails (apache#44425)
cf08d0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@MaksYermak MaksYermak MaksYermak approved these changes

@shahar1 shahar1 shahar1 approved these changes

Assignees
No one assigned
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudBatchSubmitJobOperator incorrectly reports success when defer mode is off
4 participants
@SuccessMoses @potiuk @MaksYermak @shahar1