Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support connection extra parameters in MsSqlHook #44310

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Nov 23, 2024

closes: #43798


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@jx2lee
Copy link
Contributor Author

jx2lee commented Nov 23, 2024

Until test passed, I'm keeping Draft this. 🤣
@shahar1

@jx2lee jx2lee force-pushed the enable-mssql-extra branch 2 times, most recently from 10a89ab to 030efe1 Compare November 24, 2024 14:38
@jx2lee jx2lee marked this pull request as ready for review November 24, 2024 14:53
@jx2lee
Copy link
Contributor Author

jx2lee commented Nov 24, 2024

@shahar1 when I moved Connection instance to test class, tests can pass!
Review test code, please. 🙇🏽

(Thanks, @potiuk , for the hint)

@shahar1 shahar1 self-requested a review November 24, 2024 15:36
@jx2lee jx2lee force-pushed the enable-mssql-extra branch from 030efe1 to 131c25e Compare November 25, 2024 08:45
@shahar1 shahar1 merged commit e464539 into apache:main Nov 26, 2024
62 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* enable extras

* mark db_test

* connections to fixture
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* enable extras

* mark db_test

* connections to fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsSql hook does not use extra parameters when creating PymssqlConnection
2 participants