-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fixed databricks repair run deferrable #44213
[FIX] Fixed databricks repair run deferrable #44213
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will need to get the tests fixed |
Sure, will look into that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix the CI issue before merging
@Lee-W can you please review and merge this bug fix PR |
Sure, will take a look once the test and CI pass |
@Lee-W Made some changes. Those failing CI tests should be fixed now. Could you please review? |
ad55a15
to
7010343
Compare
rebased from the latest main to see whether the last test passes |
@Lee-W Passed the CI tests. Could you please review now? |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* [FIX] Fixed databricks repair run deferrable * Removed trailing spaces as per pre-commit hook * [Fix] Modified code to handle invalid trigger event
* [FIX] Fixed databricks repair run deferrable * Removed trailing spaces as per pre-commit hook * [Fix] Modified code to handle invalid trigger event
* [FIX] Fixed databricks repair run deferrable * Removed trailing spaces as per pre-commit hook * [Fix] Modified code to handle invalid trigger event
_handle_deferrable_databricks_operator_completion
is assuming repair_run will always be called in case of repair_run = True however after new_settings change, that decision also include reason match and hence flow exit with execute_complete method. These changes will consider the settings and then run for repair run flow.@Lee-W
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.