Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-84 Get Mapped Task Instance Try Details #44206

Conversation

kandharvishnu
Copy link
Contributor

related to: #42370


@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 20, 2024
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 20, 2024
Copy link
Collaborator

@rawwar rawwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove prints

@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_try_details branch from 921f1a8 to 5a34649 Compare November 20, 2024 14:20
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_mapped_task_instance_try_details branch from 5a34649 to 09908c1 Compare November 20, 2024 15:44
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall beside @rawwar comments.

@kandharvishnu
Copy link
Contributor Author

Looking good overall beside @rawwar comments.

yes, removed the print statements

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks.

@kandharvishnu kandharvishnu requested a review from rawwar November 20, 2024 16:28
@rawwar
Copy link
Collaborator

rawwar commented Nov 20, 2024

Just noticed logical_date is missing in response model(TaskInstanceHistoryResponse). Is this intentional ?

@kandharvishnu
Copy link
Contributor Author

kandharvishnu commented Nov 20, 2024

Just noticed logical_date is missing in response model(TaskInstanceHistoryResponse). Is this intentional ?

TaskInstanceHistoryResponse return logical_date
image

@rawwar
Copy link
Collaborator

rawwar commented Nov 20, 2024

I saw the response Here and saw it had execution_date

@kandharvishnu
Copy link
Contributor Author

I saw the response Here and saw it had execution_date

I have raised a PR to fix that - #43830

@pierrejeambrun pierrejeambrun merged commit d11a504 into apache:main Nov 20, 2024
62 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
* adding get_mapped_task_instance_try_details

* dummy change

* revert dummy change

* removing print statements

---------

Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* adding get_mapped_task_instance_try_details

* dummy change

* revert dummy change

* removing print statements

---------

Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants