-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-84 Get Mapped Task Instance Try Details #44206
AIP-84 Get Mapped Task Instance Try Details #44206
Conversation
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove prints
921f1a8
to
5a34649
Compare
5a34649
to
09908c1
Compare
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall beside @rawwar comments.
yes, removed the print statements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks.
Just noticed logical_date is missing in response model(TaskInstanceHistoryResponse). Is this intentional ? |
I saw the response Here and saw it had execution_date |
* adding get_mapped_task_instance_try_details * dummy change * revert dummy change * removing print statements --------- Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
* adding get_mapped_task_instance_try_details * dummy change * revert dummy change * removing print statements --------- Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
related to: #42370