Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing mypy check on main #44191

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 19, 2024

Failure on main:

providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Module "airflow.security.kerberos" has no attribute "get_kerberos_principle";
maybe "get_kerberos_principal"?  [attr-defined]
                from airflow.security.kerberos import (
                ^
providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Name "get_kerberos_principal" already defined (possibly by an import)
[no-redef]
                from airflow.security.kerberos import (
                ^
Found 2 errors in 1 file (checked 3337 source files)
Error 1 returned

Example: https://github.com/apache/airflow/actions/runs/11916279945/job/33209076757


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Failure on main:

```
providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Module "airflow.security.kerberos" has no attribute "get_kerberos_principle";
maybe "get_kerberos_principal"?  [attr-defined]
                from airflow.security.kerberos import (
                ^
providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Name "get_kerberos_principal" already defined (possibly by an import)
[no-redef]
                from airflow.security.kerberos import (
                ^
Found 2 errors in 1 file (checked 3337 source files)
Error 1 returned
```
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. I have personally always gotten confused between principal and principle

LGTM

@eladkal eladkal merged commit 7747b7b into apache:main Nov 19, 2024
62 checks passed
@potiuk
Copy link
Member

potiuk commented Nov 19, 2024

Nice!

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Failure on main:

```
providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Module "airflow.security.kerberos" has no attribute "get_kerberos_principle";
maybe "get_kerberos_principal"?  [attr-defined]
                from airflow.security.kerberos import (
                ^
providers/src/airflow/providers/apache/spark/hooks/spark_submit.py:525: error:
Name "get_kerberos_principal" already defined (possibly by an import)
[no-redef]
                from airflow.security.kerberos import (
                ^
Found 2 errors in 1 file (checked 3337 source files)
Error 1 returned
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants