Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude src/airflow/__init__.py when building providers #44066

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 15, 2024

same as Task SDK change in #43899 -- but for providers


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

same as Task SDK change in apache#43899 -- but for providers
@kaxil kaxil requested review from ashb, potiuk and dstandish November 15, 2024 17:30
@ashb
Copy link
Member

ashb commented Nov 15, 2024

Makes sense, even though this isn't a real package it can confuse things if it's there.

@kaxil kaxil merged commit eed59f1 into apache:main Nov 15, 2024
37 checks passed
@kaxil kaxil deleted the exclude-airflow-init branch November 15, 2024 17:52
@potiuk
Copy link
Member

potiuk commented Nov 15, 2024

Does it mean that our packages from release are broken ? cc: @eladkal ? I guess we need to re-release them? Or do they work as usual? (I did not have time to check them)

@kaxil
Copy link
Member Author

kaxil commented Nov 15, 2024

Does it mean that our packages from release are broken ? cc: @eladkal ? I guess we need to re-release them? Or do they work as usual? (I did not have time to check them)

They are good as while preparing provider packages we copy the a specific provider directory e.g. providers/src/airflow/providers/apache/hdfs.

def test_get_source_package_path():
assert get_source_package_path("apache.hdfs") == AIRFLOW_SOURCES_ROOT.joinpath(
"providers", "src", "airflow", "providers", "apache", "hdfs"
)

AIRFLOW_PROVIDERS_NS_PACKAGE = AIRFLOW_PROVIDERS_SRC / "airflow" / "providers"

❯ tree apache_airflow_providers_amazon-9.1.0rc4-py3-none-any
apache_airflow_providers_amazon-9.1.0rc4-py3-none-any
├── airflow
│   └── providers
│       └── amazon

@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

UFF 😓

@eladkal
Copy link
Contributor

eladkal commented Nov 16, 2024

I don't see any problem with current rc of providers. If you find something is wrong let me know

@potiuk
Copy link
Member

potiuk commented Nov 16, 2024

I don't see any problem with current rc of providers. If you find something is wrong let me know

Confirmed - no probl;ems.

kandharvishnu pushed a commit to kandharvishnu/airflow that referenced this pull request Nov 19, 2024
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants