-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add prominent deprecations notice via css #43909
Conversation
Could you include before and after pics please? And if we use |
Screenshots are here: #41532 (comment) |
For There are other operators that use So the styling appears to apply to all docstrings, which use the |
@ashb Did I provide enough screenshots? Are there any other concerns? |
We should do the same for all deprecated operators too |
That would be great. I could go through and apply this update to all deprecated operators. Unfortunately, it's a manual effort. I did mention something about extending the Sphinx |
You need to rebase/resolve conflicts @geraj1010 |
No problem, I can help with applying this update to all deprecated operators. @kaxil @potiuk Shall I raise a separate PR with commits from this PR or something else, please let me know. Thank you :) |
If @geraj1010 is ok with it, absolutely - feel free. |
I think we can merge this one to credit @geraj1010 |
I resolved the conflict, and merged |
@eladkal Worth including this change in the next batch of providers |
Thanks a lot for looking into this @kaxil, and kudos @geraj1010 for this PR! I've raised #44479 to use the warning block wherever applicable, so that we can show these prominent deprecation warnings consistently across Airflow docs. Cheers. |
My pleasure! |
Greetings, I was away for the holidays. Thank you all for review! @kaxil Thank you for resolving the conflict. Can you please tell me what it was? |
Hi @geraj1010 , I hope you had a good holiday. Your base branch was 1000 commits behind the Airflow main -- Example: https://github.com/apache/airflow/commits/39ebd75c5cb066218a2b6b3940eddc217dd816d9/docs/sphinx_design/static/custom.css -- your branch's base commit was from December 2023 -- so rebased on the main branch. ![]() |
Ahh I see! I wonder how that happened? I've only started contributing in August 2024. Maybe I forked the repo incorrectly? |
Updated deprecated Bigquery docstrings with the
.. warning::
admonition and added custom CSS styling, which will apply to all.. warning::
admonitions found in docstrtings.closes #41532