Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add prominent deprecations notice via css #43909

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

geraj1010
Copy link
Contributor

@geraj1010 geraj1010 commented Nov 12, 2024


Updated deprecated Bigquery docstrings with the .. warning:: admonition and added custom CSS styling, which will apply to all .. warning:: admonitions found in docstrtings.

closes #41532

@ashb
Copy link
Member

ashb commented Nov 12, 2024

Could you include before and after pics please?

And if we use .. warning:: anywhere else before and after of one those too please

@kaxil
Copy link
Member

kaxil commented Nov 12, 2024

Screenshots are here: #41532 (comment)

@geraj1010
Copy link
Contributor Author

geraj1010 commented Nov 13, 2024

For BigQueryExecuteQueryOperator:

Before:
image

After:
image

There are other operators that use .. warning:: in their docstring, here is CloudDataTransferServiceCreateJobOperator

Before:
image

After:
image

So the styling appears to apply to all docstrings, which use the .. warning:: admonition (since the CSS is in docs/sphinx_design/static/custom.css) . If that is an issue, I could create a .css specifically for Google Providers if that helps. Then that would restrict the styling to Google Providers.

@geraj1010
Copy link
Contributor Author

@ashb Did I provide enough screenshots? Are there any other concerns?

@kaxil kaxil changed the title Airflow 41532: Updated Bigquery Deprecated Operator Docstrings Updated Bigquery Deprecated Operator Docstrings Nov 15, 2024
@kaxil
Copy link
Member

kaxil commented Nov 15, 2024

We should do the same for all deprecated operators too

@geraj1010
Copy link
Contributor Author

We should do the same for all deprecated operators too

That would be great. I could go through and apply this update to all deprecated operators. Unfortunately, it's a manual effort. I did mention something about extending the Sphinx AutoAPI extension (#41532 (comment)), but that would take more work for sure.

@potiuk
Copy link
Member

potiuk commented Nov 28, 2024

You need to rebase/resolve conflicts @geraj1010

@omkar-foss
Copy link
Collaborator

omkar-foss commented Nov 28, 2024

I could go through and apply this update to all deprecated operators. Unfortunately, it's a manual effort. I did mention something about extending the Sphinx AutoAPI extension (#41532 (comment)), but that would take more work for sure.

No problem, I can help with applying this update to all deprecated operators.

@kaxil @potiuk Shall I raise a separate PR with commits from this PR or something else, please let me know. Thank you :)

@potiuk
Copy link
Member

potiuk commented Nov 28, 2024

@kaxil @potiuk Shall I raise a separate PR with commits from this PR or something else, please let me know. Thank you :)

If @geraj1010 is ok with it, absolutely - feel free.

@kaxil
Copy link
Member

kaxil commented Nov 28, 2024

I could go through and apply this update to all deprecated operators. Unfortunately, it's a manual effort. I did mention something about extending the Sphinx AutoAPI extension (#41532 (comment)), but that would take more work for sure.

No problem, I can help with applying this update to all deprecated operators.

@kaxil @potiuk Shall I raise a separate PR with commits from this PR or something else, please let me know. Thank you :)

I think we can merge this one to credit @geraj1010

@kaxil kaxil changed the title Updated Bigquery Deprecated Operator Docstrings Docs: Add prominent deprecations notice via css Nov 29, 2024
@kaxil kaxil merged commit 840018a into apache:main Nov 29, 2024
36 checks passed
@kaxil
Copy link
Member

kaxil commented Nov 29, 2024

I resolved the conflict, and merged

@kaxil
Copy link
Member

kaxil commented Nov 29, 2024

Verified it locally:

image

@kaxil kaxil added this to the Airflow 2.10.4 milestone Nov 29, 2024
@kaxil
Copy link
Member

kaxil commented Nov 29, 2024

@eladkal Worth including this change in the next batch of providers

@omkar-foss
Copy link
Collaborator

Thanks a lot for looking into this @kaxil, and kudos @geraj1010 for this PR!

I've raised #44479 to use the warning block wherever applicable, so that we can show these prominent deprecation warnings consistently across Airflow docs. Cheers.

@geraj1010
Copy link
Contributor Author

Thanks a lot for looking into this @kaxil, and kudos @geraj1010 for this PR!

I've raised #44479 to use the warning block wherever applicable, so that we can show these prominent deprecation warnings consistently across Airflow docs. Cheers.

My pleasure!

@geraj1010
Copy link
Contributor Author

Greetings, I was away for the holidays. Thank you all for review!

@kaxil Thank you for resolving the conflict. Can you please tell me what it was?

@geraj1010 geraj1010 deleted the airflow_41532 branch December 1, 2024 03:15
@kaxil
Copy link
Member

kaxil commented Dec 1, 2024

Greetings, I was away for the holidays. Thank you all for review!

@kaxil Thank you for resolving the conflict. Can you please tell me what it was?

Hi @geraj1010 , I hope you had a good holiday. Your base branch was 1000 commits behind the Airflow main -- Example: https://github.com/apache/airflow/commits/39ebd75c5cb066218a2b6b3940eddc217dd816d9/docs/sphinx_design/static/custom.css -- your branch's base commit was from December 2023 -- so rebased on the main branch.

image

@geraj1010
Copy link
Contributor Author

geraj1010 commented Dec 1, 2024

Greetings, I was away for the holidays. Thank you all for review!
@kaxil Thank you for resolving the conflict. Can you please tell me what it was?

Hi @geraj1010 , I hope you had a good holiday. Your base branch was 1000 commits behind the Airflow main -- Example: https://github.com/apache/airflow/commits/39ebd75c5cb066218a2b6b3940eddc217dd816d9/docs/sphinx_design/static/custom.css -- your branch's base commit was from December 2023 -- so rebased on the main branch.

Ahh I see! I wonder how that happened? I've only started contributing in August 2024. Maybe I forked the repo incorrectly?

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of operators should be prominently highlighted instead of the one line remark in the documentation
5 participants