Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Get Task Instance Try Details #43675

Merged
merged 6 commits into from
Nov 19, 2024
Merged

AIP-84 Get Task Instance Try Details #43675

merged 6 commits into from
Nov 19, 2024

Conversation

kandharvishnu
Copy link
Contributor

related to: #42370

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 5, 2024
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 5, 2024
@kandharvishnu kandharvishnu marked this pull request as ready for review November 5, 2024 08:11
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_task_instance_try_details branch from 1167edf to 7a55eb9 Compare November 5, 2024 17:54
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_task_instance_try_details branch 2 times, most recently from d42bb1b to bcd3c81 Compare November 15, 2024 06:37
@kandharvishnu kandharvishnu requested a review from rawwar November 15, 2024 06:39
@kandharvishnu kandharvishnu requested a review from rawwar November 15, 2024 09:12
@pierrejeambrun pierrejeambrun mentioned this pull request Nov 15, 2024
Closed
1 task
@pierrejeambrun
Copy link
Member

Need rebasing as well.

pierrejeambrun
pierrejeambrun reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, a few suggestions, thanks

@pierrejeambrun
Copy link
Member

Needs rebasing. We can merge after the small adjustments are done.

@kandharvishnu kandharvishnu force-pushed the AIP-84_get_task_instance_try_details branch from 7f7d8b4 to 8f534ab Compare November 19, 2024 03:46
@kandharvishnu kandharvishnu force-pushed the AIP-84_get_task_instance_try_details branch from 8f534ab to bde8478 Compare November 19, 2024 05:06
@pierrejeambrun pierrejeambrun merged commit e964c64 into apache:main Nov 19, 2024
62 checks passed
@rawwar
Copy link
Collaborator

rawwar commented Nov 19, 2024

Nice! On to the next one @kandharvishnu

LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
@kandharvishnu
AIP-84 Get Task Instance Try Details (apache#43675)
84921c0 
* adding GetTaskInstanceTryDetails

* adding test cases

* changing status code

* removing 401,403 code

* removing async

* adding types and rebase

---------

Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawwar rawwar rawwar left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@potiuk potiuk Awaiting requested review from potiuk

@ashb ashb Awaiting requested review from ashb

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

@eladkal eladkal Awaiting requested review from eladkal

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

@mik-laj mik-laj Awaiting requested review from mik-laj

@hussein-awala hussein-awala Awaiting requested review from hussein-awala

@uranusjr uranusjr Awaiting requested review from uranusjr

@dstandish dstandish Awaiting requested review from dstandish

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kandharvishnu @pierrejeambrun @rawwar