Move triggers and remaining operators/sensors into standard provider #43571
Conversation
airflow/models/dag.py
Outdated
| @@ -73,7 +73,7 @@ | |||
|
|
|||
| from airflow import settings, utils | |||
| from airflow.api_internal.internal_api_call import internal_api_call | |||
| from airflow.assets import Asset, AssetAlias, BaseAsset | |||
There was a problem hiding this comment.
why we removed it here?
There was a problem hiding this comment.
Yeah, it removed by mistake when moving and import resolution, will update. :)
| @@ -846,6 +846,7 @@ | |||
| "plugins": [], | |||
| "cross-providers-deps": [ | |||
| "amazon", | |||
| "common.compat", | |||
There was a problem hiding this comment.
why we need this change here?
There was a problem hiding this comment.
We are using compat provider for imports to work with old core location. so here in this case msgraph uses timedelta, https://github.com/apache/airflow/pull/43571/files/a750af6fec2a04ba5a347303fb4397a4e496d56e#diff-af3b61e0f2e76a9841ce87162351100deee4bc736a90d4cb8715acd9fb61473cR23
pre-commit generated this with common.compat as cross provider
|
Does email operator/email utils is required to move inside standard provider? |
|
This pr getting more and more changes i feel and some changes require in selective checks to remove Will update this later. |
Makes sense |
|
Do we still need this PR or was it break into smaller ones that were already merged? |
Don't think this is required, kept open to double check the final checks. I think we are good I will close this. |
Moving core area triggers and remaining operators/sensors inside standard provider
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.