-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate new UI to Chakra v3 #43523
Migrate new UI to Chakra v3 #43523
Conversation
9073063
to
5172259
Compare
Fix react-select and tests Rename alert.tsx to Alert.tsx Rename menu.tsx to Menu.tsx Rename tag.tsx to Tag.tsx Rename tooltip.tsx to Tooltip.tsx Add licenses Add index to components/ui Simplify NavButton with new chakra triggers
8aa8afd
to
ac8b853
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🎉
I just noticed a small issue with the switch to pause/unpause
dags. Request is sent and successful but in the UI it's not correctly displayed, if I refresh things are right. (stays paused or unpaused without refreshing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to upgrade / switch early!
A lot of UI components are added inthe PR - I assume they are missing (atm) in 3.0.0 and hopefully will be added upstream later such that we can drop the local code?
I also saw a small in-consistency - but maybe already have been before? When I enable/disable DAGs and switch from card to list view, state is not carried over. Also I think some small glitches (not sure if have been like this before) when filtering ans switching card/list view, then filters are reset. Not critical to merge.
LGTM! (Wow a big change!)
Chakra v3 switched to open components which gives a lot easier ways to customize them, but also means you need to build a lot yourself. Hence the new Pierre had a similar issue with the pause/unpause dags. Somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff—looks great!
Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
Sorry, too late... but comments were not planned to block merge... so all good! |
* Migrate to chakra v3 Fix react-select and tests Rename alert.tsx to Alert.tsx Rename menu.tsx to Menu.tsx Rename tag.tsx to Tag.tsx Rename tooltip.tsx to Tooltip.tsx Add licenses Add index to components/ui Simplify NavButton with new chakra triggers * Clean up default exports and tsx->ts filenames * Update airflow/ui/src/components/ui/index.ts Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com> * Fix styling from code suggestion --------- Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
Chakra v3 came out last week. Its a really big change. So its better than we migrate sooner rather than later. By the time Airflow 3 comes out it won't be at 3.0.0 anymore.
Closes: #43483
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.