Caching yarn and pnpm dependencies in Docker #43329
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # shellcheck shell=bash disable=SC2086 | ||
|
|
||
| # shellcheck source=scripts/docker/common.sh | ||
| . "$( dirname "${BASH_SOURCE[0]}" )/common.sh" | ||
|
|
||
| # Install npm, pnpm and yarn function | ||
| function install_npm_pnpm_yarn() { | ||
| echo | ||
| echo "${COLOR_BLUE}Installing npm, pnpm and yarn${COLOR_RESET}" | ||
| echo | ||
| set -e | ||
| set -x | ||
| # Install npm | ||
| apt-get update | ||
| apt-get install -y npm | ||
| # Install pnpm | ||
| npm install -g pnpm | ||
| # Install yarn | ||
| npm install -g yarn | ||
| echo "${COLOR_BLUE}npm, pnpm and yarn installed successfully${COLOR_RESET}" | ||
| set +x | ||
| set +e | ||
| } | ||
|
|
||
| common::get_colors | ||
|
|
||
| install_npm_pnpm_yarn |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| #!/usr/bin/env bash | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # shellcheck shell=bash disable=SC2086 | ||
|
|
||
| # Installs pnpm dependencies from $AIRFLOW_BRANCH tip. This is pure optimization. It is done because we do not want | ||
| # to reinstall all dependencies from scratch when package.json changes. Problem with Docker caching is that | ||
| # when a file is changed, when added to docker context, it invalidates the cache and it causes Docker | ||
| # build to reinstall all dependencies from scratch. This can take a loooooot of time. Therefore we install | ||
| # the dependencies first from main (and uninstall airflow right after) so that we can start installing | ||
| # deps from those pre-installed dependencies. It saves few minutes of build time when package.json changes. | ||
| # | ||
| # shellcheck source=scripts/docker/common.sh | ||
| . "$( dirname "${BASH_SOURCE[0]}" )/common.sh" | ||
|
|
||
| : "${AIRFLOW_REPO:?Should be set}" | ||
| : "${AIRFLOW_BRANCH:?Should be set}" | ||
|
|
||
| function install_pnpm_dependencies_from_branch_tip() { | ||
| echo | ||
| echo "${COLOR_BLUE}Installing pnpm dependencies from ${AIRFLOW_BRANCH}. It is used to cache dependencies${COLOR_RESET}" | ||
| echo | ||
| local TEMP_AIRFLOW_DIR | ||
| TEMP_AIRFLOW_DIR=$(mktemp -d) | ||
|
|
||
| # Download the source code from the specified branch | ||
| set -e | ||
| set -x | ||
| curl -fsSL "https://github.com/${AIRFLOW_REPO}/archive/${AIRFLOW_BRANCH}.tar.gz" | \ | ||
| tar xz -C "${TEMP_AIRFLOW_DIR}" --strip 1 | ||
|
|
||
| # Install pnpm dependencies | ||
| cd "${TEMP_AIRFLOW_DIR}/airflow/ui" | ||
| pnpm install --frozen-lockfile --config.confirmModulesPurge=false | ||
| set +x | ||
| set +e | ||
| echo "${COLOR_BLUE}pnpm dependencies installed successfully${COLOR_RESET}" | ||
|
|
||
| # Copy pnpm packages to the .pnpm-cache directory | ||
| echo | ||
| echo "${COLOR_BLUE}Copying pnpm packages to the ${PNPM_CACHE_DIR} directory${COLOR_RESET}" | ||
| echo | ||
| set -e | ||
| set -x | ||
| cp -r ./node_modules $PNPM_CACHE_DIR/ | ||
| echo "${COLOR_BLUE}pnpm packages copied successfully${COLOR_RESET}" | ||
| set +x | ||
|
|
||
| # Clean up | ||
| rm -rf "${TEMP_AIRFLOW_DIR}" | ||
| set +e | ||
| } | ||
|
|
||
| common::get_colors | ||
|
|
||
| install_pnpm_dependencies_from_branch_tip |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small tthing here. I think we should ALWAYS run the install step below. This covers case where the .lock file changed in the meantime and we just need to update it based on pre-cached node_modules