Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airflow 3 ui & task_sdk directories to .gitignore #43319

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 23, 2024

These directories are ignored so someone can develop on both (AF2 and AF3) of them without deleting files manually.

Without it I had to manually delete all the UI files


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

These directories are ignored so someone can develop on both of them without deleting files manually.

Without it I had to manually delete all the UI files
@kaxil kaxil added this to the Airflow 2.10.3 milestone Oct 23, 2024
@kaxil kaxil requested a review from shahar1 October 23, 2024 15:19
Copy link
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a second to figure out that it's not merged to main 😅
LGTM

@kaxil kaxil merged commit 0c6c850 into apache:v2-10-test Oct 24, 2024
33 checks passed
@kaxil kaxil deleted the git-ignore-af3 branch October 24, 2024 10:09
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 24, 2024
utkarsharma2 pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants