Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dataset as asset in UI #43073

Merged
merged 18 commits into from
Oct 23, 2024
Merged

Rename dataset as asset in UI #43073

merged 18 commits into from
Oct 23, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 16, 2024 •
edited
Loading

As part of #42307

Rename DagRunTriggeredByType.DATASET as DagRunTriggeredByType.ASSET and all the name dataset in all the UI components to asset.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:db-migrations PRs with DB migration area:Scheduler including HA (high availability) scheduler area:serialization area:UI Related to UI/UX. For Frontend Developers. labels Oct 16, 2024
@Lee-W Lee-W added legacy ui Whether legacy UI change should be allowed in PR legacy api Whether legacy API changes should be allowed in PR labels Oct 16, 2024
@Lee-W Lee-W force-pushed the rename-dataset-as-asset-in-ui branch from 6bd7966 to 1513ace Compare October 16, 2024 11:23
@Lee-W Lee-W mentioned this pull request Oct 16, 2024
Closed
2 tasks
@Lee-W Lee-W force-pushed the rename-dataset-as-asset-in-ui branch 12 times, most recently from cbaedd7 to aad1ea8 Compare October 21, 2024 10:46
@Lee-W Lee-W marked this pull request as ready for review October 21, 2024 10:47
Lee-W added 17 commits October 22, 2024 17:33
@Lee-W
feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents
0697a5a
@Lee-W
feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents
b58a717
@Lee-W
feat(airflow/www): rename DatasetNode as AssetNode
d080151
@Lee-W
feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets
0181def
@Lee-W
feat(airflow/www): rename DatasetDependencies as AssetDependencies
4ce9bb3
@Lee-W
feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges
6813f5b
@Lee-W
feat(airflow/www): rename DatasetListItem as AssetListItem
1ed5c1e
@Lee-W
feat(airflow/www): rename DatasetGraph as AssetGraph
2d7d2a3
@Lee-W
feat(airflow/www): rename DatasetsData as AssetsData
cb374ee
@Lee-W
feat(airflow/www): rename dataset as asset in ts* files
2608eef
@Lee-W
feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/…
5ae26fe 
…static/js/assets
@Lee-W
feat(airflow/www): rename dataset as asset in js files
372a897
@Lee-W
feat(airflow/www): rename dataset as asset in html files
18cdb22
@Lee-W
test(www): rename test_views_dataset as test_views_asset
b9a24a7
@Lee-W
feat: rename dataset as asset in other files
8ebc5c2
@Lee-W
docs: update screenshots
8c0fa5b
@Lee-W
docs: add newsfragment
6ccd484
@Lee-W Lee-W force-pushed the rename-dataset-as-asset-in-ui branch from 28f27b2 to 6ccd484 Compare October 22, 2024 09:34
@bbovenzi
Copy link
Contributor

Would the backend not also have issues with backporting changes to 2.10/11?

I do agree that much of this work isn't necessary because we will be removing the /api_connexion, and /www directories. It wasn't just confusing to mix "asset" and "datasets" in the codebase, it did introduce a few bugs. So I am ok with swapping everything over for consistency's sake.

@Lee-W
Copy link
Member Author

Lee-W commented Oct 23, 2024

Would the backend not also have issues with backporting changes to 2.10/11?

Yep, whenever I need to do that kind of change, I just did them in separate branch instead of just backporting the merged commit.

I do agree that much of this work isn't necessary because we will be removing the /api_connexion, and /www directories. It wasn't just confusing to mix "asset" and "datasets" in the codebase, it did introduce a few bugs. So I am ok with swapping everything over for consistency's sake.

Thanks for confirming. If it actually introduced bugs, I think it's better to just change it in main. I'll go ahead and merge it

@Lee-W Lee-W added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Oct 23, 2024
@Lee-W Lee-W merged commit d186d3f into apache:main Oct 23, 2024
54 checks passed
@Lee-W Lee-W deleted the rename-dataset-as-asset-in-ui branch October 23, 2024 06:16
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
@Lee-W @harjeevanmaan
Rename dataset as asset in UI (apache#43073)
d30e7bd 
* feat(airflow/www): rename DatasetEventCard as AssetEventCard

* feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents

* feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents

* feat(airflow/www): rename DatasetNode as AssetNode

* feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets

* feat(airflow/www): rename DatasetDependencies as AssetDependencies

* feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges

* feat(airflow/www): rename DatasetListItem as AssetListItem

* feat(airflow/www): rename DatasetGraph as AssetGraph

* feat(airflow/www): rename DatasetsData as AssetsData

* feat(airflow/www): rename dataset as asset in ts* files

* feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets

* feat(airflow/www): rename dataset as asset in js files

* feat(airflow/www): rename dataset as asset in html files

* test(www): rename test_views_dataset as test_views_asset

* feat: rename dataset as asset in other files

* docs: update screenshots

* docs: add newsfragment
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
@Lee-W @PaulKobow7536
Rename dataset as asset in UI (apache#43073)
534053d 
* feat(airflow/www): rename DatasetEventCard as AssetEventCard

* feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents

* feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents

* feat(airflow/www): rename DatasetNode as AssetNode

* feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets

* feat(airflow/www): rename DatasetDependencies as AssetDependencies

* feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges

* feat(airflow/www): rename DatasetListItem as AssetListItem

* feat(airflow/www): rename DatasetGraph as AssetGraph

* feat(airflow/www): rename DatasetsData as AssetsData

* feat(airflow/www): rename dataset as asset in ts* files

* feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets

* feat(airflow/www): rename dataset as asset in js files

* feat(airflow/www): rename dataset as asset in html files

* test(www): rename test_views_dataset as test_views_asset

* feat: rename dataset as asset in other files

* docs: update screenshots

* docs: add newsfragment
@Lee-W Lee-W self-assigned this Oct 28, 2024
@eladkal eladkal mentioned this pull request Nov 3, 2024
Closed
25 tasks
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@Lee-W @ellisms
Rename dataset as asset in UI (apache#43073)
af21559 
* feat(airflow/www): rename DatasetEventCard as AssetEventCard

* feat(airflow/www): rename DatasetUpdateEvents as AssetUpdateEvents

* feat(airflow/www): rename DatasetTriggerEvents as AssetTriggerEvents

* feat(airflow/www): rename DatasetNode as AssetNode

* feat(airflow/www): rename getUpstreamDatasets as getUpstreamAssets

* feat(airflow/www): rename DatasetDependencies as AssetDependencies

* feat(airflow/www): rename upstreamDatasetEdges as upstreamAssetEdges

* feat(airflow/www): rename DatasetListItem as AssetListItem

* feat(airflow/www): rename DatasetGraph as AssetGraph

* feat(airflow/www): rename DatasetsData as AssetsData

* feat(airflow/www): rename dataset as asset in ts* files

* feat(airflow): rename airflow/www/static/js/datasets/ as airflow/www/static/js/assets

* feat(airflow/www): rename dataset as asset in js files

* feat(airflow/www): rename dataset as asset in html files

* test(www): rename test_views_dataset as test_views_asset

* feat: rename dataset as asset in other files

* docs: update screenshots

* docs: add newsfragment
@Lee-W Lee-W mentioned this pull request Nov 18, 2024
Open
@potiuk potiuk mentioned this pull request Jan 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl left review comments

@bbovenzi bbovenzi bbovenzi approved these changes

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees

@Lee-W Lee-W

Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:API Airflow's REST/HTTP API area:db-migrations PRs with DB migration area:Scheduler including HA (high availability) scheduler area:serialization area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR legacy ui Whether legacy UI change should be allowed in PR
Projects
AIP-74 Introducing Data Assets
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lee-W @bbovenzi @jscheffl