Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Exec: Drop params that aren't compatible with EC2 #42228

Conversation

o-nikolas
Copy link
Contributor

If using the ECS executor with the EC2 launch type, then platform_version and assign_public_ip are not applicable and cause the Boto call to fail.

fixes #41824


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

If using the ECS executor with the EC2 launch type, then
platform_version and assign_public_ip are not applicable
and cause the Boto call to fail.
@o-nikolas o-nikolas requested a review from eladkal as a code owner September 13, 2024 18:35
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Sep 13, 2024
@eladkal eladkal merged commit 4afc256 into apache:main Sep 16, 2024
56 of 57 checks passed
@vincbeck vincbeck deleted the onikolas/ecs_exec_ec2_launch_type_platform_version branch September 16, 2024 15:40
gopidesupavan pushed a commit to gopidesupavan/airflow that referenced this pull request Sep 17, 2024
If using the ECS executor with the EC2 launch type, then
platform_version and assign_public_ip are not applicable
and cause the Boto call to fail.
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
If using the ECS executor with the EC2 launch type, then
platform_version and assign_public_ip are not applicable
and cause the Boto call to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS Executor with EC2 launch type doesn't work as platform version cannot be unset which is a requirement
3 participants