Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative paths when sanitizing URLs #41995

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Handle relative paths when sanitizing URLs #41995

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28b7e05
Handle relative paths when sanitizing URLs
utkarsharma2 Sep 4, 2024
80fe5a0
Merge branch 'main' into FixisSanitised
utkarsharma2 Sep 4, 2024
a72ef5b
Add PR suggestions
utkarsharma2 Sep 4, 2024
c180cab
Merge branch 'main' into FixisSanitised
utkarsharma2 Sep 4, 2024
fc4871b
Update code comment
utkarsharma2 Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,14 @@ const ExtraLinks = ({
if (!url) {
return true;
}
const urlRegex = /^(https?:)/i;
return urlRegex.test(url);
const path = new URL(url, "http://localhost");
// Allow Absolute/Relative URL and prevent javascript:() from executing when passed as path.
// Example - `javascript:alert("Hi");`. Protocol for absolute and relative urls will either be `http:`/`https:`.
// Where as for javascript it will be `javascript:`.
if (path.protocol === "http:" || path.protocol === "https:") {
return true; // Absolute/Relative URLs are allowed
}
return false;
};

return (
Expand Down