stackdriver task_handler deprecated name arg removed

[dirrao]

stackdriver task_handler deprecated name arg removed

[uranusjr]

This is a provider change and shouldn’t be tied with Airflow 3.0. It should be tied to when we want to bump the provider’s major version, but that should likely not be the same time as Airflow 3.0 (bumping major in both would make user migration difficult).

[potiuk]

Yes. If we make provider breaking change, this requires adding a comment in CHANGELOG for that provider and bumping the major version in provider.yaml (see comment in provider's CHANGELOG at the top). And since this is a google provider - it should be coordinated with other breaking changes removal - this is being currently disucssed in #41637 with @moiseenkov

[potiuk]

requesting changes to not merge it accidentally

[moiseenkov]

Yes

Yes. If we make provider breaking change, this requires adding a comment in CHANGELOG for that provider and bumping the major version in provider.yaml (see comment in provider's CHANGELOG at the top). And since this is a google provider - it should be coordinated with other breaking changes removal - this is being currently disucssed in #41637 with @moiseenkov

Agree with @potiuk . Let's wait for the #41637 resolution and then adjust the depreciation warning here accordingly with a proper sunset date, so users would have time to migrate their code. And once the sunset is reached, we can remove this parameter along with other stuff.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[shahar1]

Just recalling that #41637 was resolved.
@dirrao do you want to continue working on that?

[dirrao]

Just recalling that #41637 was resolved.
@dirrao do you want to continue working on that?

This PR was on hold because it requires a major version release. Are we planning to proceed with the major release?

[potiuk]

@dirrao -> I think you need to synchronize with @moiseenkov @VladaZakharova @MaksYermak as the plan is to remove all deprecations (likely in Google Provider). I will remove my "request changes" but i think we need some kind of "ok now we remove all deprecations before the next release of providers" cc: @eladkal

We are getting close to "deprecation-removal" release of the Google provider.

[moiseenkov]

@dirrao -> I think you need to synchronize with @moiseenkov @VladaZakharova @MaksYermak as the plan is to remove all deprecations (likely in Google Provider). I will remove my "request changes" but i think we need some kind of "ok now we remove all deprecations before the next release of providers" cc: @eladkal

We are currently working on deprecations removal and will raise a PR soon. Once it is done, I think we will be good to proceed with this PR as well.

[moiseenkov]

Hi,
The deprecation removal PR is ready (#43953).
@dirrao , please rebase your PR on top of my branch (or rebase on top of the main branch after my PR is merged). And please add info about breaking changes into the Google provider's CHANGELOG.rst.

[dirrao]

#43953

Thanks for the update. I will rebase it once it is merged.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.